wip: fix lints

Author: mefellows

.mocharc.js

@@ -1,9 +1,10 @@
+process.env.TS_NODE_PROJECT = 'tsconfig.test.json';
+
 module.exports = {
 	exclude: '**/*.jest.spec.ts',
-	require: 'ts-node/register',
+	require: ['ts-node/register'],
 	timeout: '30000',
 	slow: '5000',
 	exit: true,
-	require: 'ts-node.js',
 	'check-leaks': true,
 };

eslint.config.mjs

@@ -1,18 +1,68 @@
-// @ts-check
-
 import eslint from '@eslint/js';
-import tseslint from 'typescript-eslint';
-
-import importPlugin from 'eslint-plugin-import';
-import chaiFriendly from 'eslint-plugin-chai-friendly';
-import mochaPlugin from 'eslint-plugin-mocha';
-import eslintConfigPrettier from 'eslint-config-prettier/flat';
+import tsPlugin from '@typescript-eslint/eslint-plugin';
+import tsParser from '@typescript-eslint/parser';
 
-export default tseslint.config(
+export default [
   eslint.configs.recommended,
-  tseslint.configs.recommended,
-  mochaPlugin.configs.recommended,
-  importPlugin.flatConfigs.recommended,
-  chaiFriendly.configs.recommendedFlat,
-  eslintConfigPrettier
-);
+  {
+    files: ['**/*.ts'],
+    ignores: ['**/*.d.ts'],
+    languageOptions: {
+      parser: tsParser,
+      globals: {
+        // Node.js globals
+        Buffer: 'readonly',
+        require: 'readonly',
+        module: 'writable',
+        exports: 'writable',
+        process: 'readonly',
+        console: 'readonly',
+        __dirname: 'readonly',
+        __filename: 'readonly',
+        // Test globals
+        describe: 'readonly',
+        context: 'readonly',
+        it: 'readonly',
+        before: 'readonly',
+        after: 'readonly',
+        beforeEach: 'readonly',
+        afterEach: 'readonly',
+      },
+    },
+    plugins: {
+      '@typescript-eslint': tsPlugin,
+    },
+    rules: {
+      'no-unused-vars': 'off',
+      '@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_' }],
+      '@typescript-eslint/no-explicit-any': 'warn',
+      'no-redeclare': 'off',
+    },
+  },
+  {
+    files: ['**/*.js'],
+    languageOptions: {
+      sourceType: 'commonjs',
+      globals: {
+        module: 'writable',
+        exports: 'writable',
+        require: 'readonly',
+        Buffer: 'readonly',
+        console: 'readonly',
+        process: 'readonly',
+        __dirname: 'readonly',
+        __filename: 'readonly',
+        describe: 'readonly',
+        context: 'readonly',
+        it: 'readonly',
+        before: 'readonly',
+        after: 'readonly',
+        beforeEach: 'readonly',
+        afterEach: 'readonly',
+      },
+    },
+    rules: {
+      'no-unused-vars': ['error', { varsIgnorePattern: '^(VERIFY_PROVIDER_RESPONSE|FfiFunctionResult|FfiLogLevelFilter|FnValidationStatus)$' }],
+    },
+  },
+];

src/ffi/index.ts

@@ -43,7 +43,7 @@ function getPlatformArchSpecificPackage() {
       resolvedPackagePath = resolvedPackagePath.replace('/package.json', '');
     }
     return resolvedPackagePath;
-  } catch (e) {
+  } catch {
     throw new Error(
       `Couldn't find npm package ${platformArchSpecificPackage} \n 💡 you can tell Pact where the npm package is located with env var $PACT_PREBUILD_PACKAGE_LOCATION`
     );
@@ -151,7 +151,7 @@ const initialiseFfi = (): typeof ffi => {
           return false;
         }
         return true;
-      } catch (error) {
+      } catch {
         return true;
       }
     });

src/ffi/types.ts

@@ -8,7 +8,7 @@ export type FfiMessageHandle = number;
 // TODO: Replace this pattern of type + const + lint disable with enums
 
 export type FfiSpecificationVersion = 0 | 1 | 2 | 3 | 4 | 5;
- 
+
 export const FfiSpecificationVersion: Record<string, FfiSpecificationVersion> =
   {
     SPECIFICATION_VERSION_UNKNOWN: 0,
@@ -20,7 +20,7 @@ export const FfiSpecificationVersion: Record<string, FfiSpecificationVersion> =
   };
 
 export type FfiWritePactResponse = 0 | 1 | 2 | 3;
- 
+
 export const FfiWritePactResponse: Record<string, FfiWritePactResponse> = {
   SUCCESS: 0,
   GENERAL_PANIC: 1,
@@ -29,7 +29,7 @@ export const FfiWritePactResponse: Record<string, FfiWritePactResponse> = {
 };
 
 export type FfiWriteMessagePactResponse = 0 | 1 | 2;
- 
+
 export const FfiWriteMessagePactResponse: Record<
   string,
   FfiWriteMessagePactResponse
@@ -40,7 +40,7 @@ export const FfiWriteMessagePactResponse: Record<
 };
 
 export type FfiConfigurePluginResponse = 0 | 1 | 2 | 3;
- 
+
 export const FfiConfigurePluginResponse: Record<
   string,
   FfiConfigurePluginResponse
@@ -52,7 +52,7 @@ export const FfiConfigurePluginResponse: Record<
 };
 
 export type FfiPluginInteractionResponse = 0 | 1 | 2 | 3 | 4 | 5 | 6;
- 
+
 export const FfiPluginInteractionResponse: Record<
   string,
   FfiPluginInteractionResponse
@@ -87,7 +87,7 @@ export const CREATE_MOCK_SERVER_ERRORS = {
 -5	The address is not valid
 -6	Could not create the TLS configuration with the self-signed certificate
 */
- 
+
 export enum VERIFY_PROVIDER_RESPONSE {
   VERIFICATION_SUCCESSFUL = 0,
   VERIFICATION_FAILED,

src/index.spec.ts

@@ -1,10 +1,8 @@
-import * as chai from 'chai';
-import index from './index';
+import { expect } from 'chai';
+import pact from './index';
 
-const { expect } = chai;
-
-describe('Index Spec', function() {
-  it('Typescript import should work', function() {
-    expect(index).to.be.ok;
+describe('Index Spec', function () {
+  it('Typescript import should work', function () {
+    expect(pact).to.be.ok;
   });
 });

src/index.ts

@@ -1,6 +1,5 @@
 import pact from './pact';
 
- 
 module.exports = exports = pact;
 
 export default pact;

src/logger/index.ts

@@ -4,7 +4,7 @@ import { LogLevel } from './types';
 
 // TODO: Replace this hack with https://www.npmjs.com/package/@npmcli/package-json
 // TODO: abstract this so it's not repeated in src/verifier/nativeVerifier.ts
- 
+
 const pkg = require('../../package.json');
 
 const logContext = `pact-core@${pkg.version}`;

src/pact.spec.ts

@@ -4,38 +4,40 @@ import pact from './pact';
 
 chai.use(chaiAsPromised);
 
-describe('Pact Spec', function() {
-  describe('Set Log Level', function() {
+describe('Pact Spec', function () {
+  describe('Set Log Level', function () {
     let originalLogLevel: any;
     // Reset log level after the tests
-    before(function() {
+    before(function () {
       originalLogLevel = pact.logLevel();
     });
 
-    after(function() { return pact.logLevel(originalLogLevel); });
+    after(function () {
+      return pact.logLevel(originalLogLevel);
+    });
 
-    context('when setting a log level', function() {
-      it("should be able to set log level 'trace'", function() {
+    context('when setting a log level', function () {
+      it("should be able to set log level 'trace'", function () {
         pact.logLevel('trace');
         pact.logLevel();
       });
 
-      it("should be able to set log level 'debug'", function() {
+      it("should be able to set log level 'debug'", function () {
         pact.logLevel('debug');
         pact.logLevel();
       });
 
-      it("should be able to set log level 'info'", function() {
+      it("should be able to set log level 'info'", function () {
         pact.logLevel('info');
         pact.logLevel();
       });
 
-      it("should be able to set log level 'warn'", function() {
+      it("should be able to set log level 'warn'", function () {
         pact.logLevel('warn');
         pact.logLevel();
       });
 
-      it("should be able to set log level 'error'", function() {
+      it("should be able to set log level 'error'", function () {
         pact.logLevel('error');
         pact.logLevel();
       });

src/verifier/nativeVerifier.ts

@@ -7,7 +7,7 @@ import { setupVerification } from './argumentMapper';
 
 // TODO: Replace this hack with https://www.npmjs.com/package/@npmcli/package-json
 // TODO: abstract this so it's not repeated in src/logger.ts
- 
+
 const pkg = require('../../package.json');
 
 export const verify = (opts: VerifierOptions): Promise<string> => {