added test for findItemsByKeyword

Author: pajaydev

src/buildURL.js

@@ -16,7 +16,7 @@ const buildURL = {
         let base_url = "http://svcs.ebay.com/services/search/FindingService/v1?";
         base_url += "SECURITY-APPNAME=" + options.clientID;
         base_url += "&OPERATION-NAME=" + options.operationName;
-        base_url += "&SERVICE-VERSION=1.0.0&RESPONSE-DATA-FORMAT=JSON&REST-PAYLOAD";
+        base_url += "&SERVICE-VERSION=1.0.0&RESPONSE-DATA-FORMAT=JSON";
         base_url += options.param ? "&" + options.param + "=" + options.name : '';
         base_url += options.limit ? "&paginationInput.entriesPerPage=" + options.limit : '';
         base_url += options.globalID ? "&GLOBAL-ID=" + options.globalID : '';

src/index.js

@@ -15,6 +15,8 @@ function Ebay(options) {
 Ebay.prototype = {
 
     findItemsByKeywords: function (keyword) {
+        // console.log("keyword" + keyword);
+        if (!keyword) throw new Error("Keyword is missing, Keyword is required");
         this.options.name = keyword;
         this.options.operationName = "findItemsByKeywords";
         this.options.param = "keywords";

test/testBuildURL.js renamed to test/buildURL.test.js

@@ -7,7 +7,7 @@ describe("test building url methods", () => {
 
 
     it("test search url", () => {
-        let expected_search_url = "http://svcs.ebay.com/services/search/FindingService/v1?SECURITY-APPNAME=testID&OPERATION-NAME=findItemsByKeywords&SERVICE-VERSION=1.0.0&RESPONSE-DATA-FORMAT=JSON&REST-PAYLOAD&keywords=iphone&paginationInput.entriesPerPage=6&GLOBAL-ID=EBAY-US"
+        let expected_search_url = "http://svcs.ebay.com/services/search/FindingService/v1?SECURITY-APPNAME=testID&OPERATION-NAME=findItemsByKeywords&SERVICE-VERSION=1.0.0&RESPONSE-DATA-FORMAT=JSON&keywords=iphone&paginationInput.entriesPerPage=6&GLOBAL-ID=EBAY-US"
         let options = {
             name: "iphone",
             operationName: "findItemsByKeywords",

test/findItemsByKeyword.test.js

@@ -0,0 +1,42 @@
+const nock = require('nock');
+const eBay = require('../src/index');
+let expect = require("chai").expect;
+
+describe("Test find items by keyword method", () => {
+
+    beforeEach(() => {
+        nock('http://svcs.ebay.com')
+            .get('/services/search/FindingService/v1')
+            .query({
+                'SECURITY-APPNAME': 'ClientId',
+                'OPERATION-NAME': 'findItemsByKeywords',
+                'SERVICE-VERSION': '1.0.0',
+                'RESPONSE-DATA-FORMAT': 'JSON',
+                'keywords': 'iphone',
+                'GLOBAL-ID': 'EBAY-US'
+
+            })
+            .reply(200, {
+                "access_token": "abcd"
+            });
+    });
+
+    it("test input parameter in findItemsByKeyword method", () => {
+        let ebay = new eBay({
+            clientID: "ClientId"
+        })
+        expect(() => { ebay.findItemsByKeywords() }).to.throw("Keyword is missing, Keyword is required");
+    });
+
+    it("test get items from findItemsByKeyword method", () => {
+        let ebay = new eBay({
+            clientID: "ClientId",
+        })
+
+        return ebay.findItemsByKeywords("iphone").then((response) => {
+            console.log("------" + response);
+            //done();
+        })
+    })
+
+})