code cleanup and fix linting (#37)

* code cleanup and fix linting

* remove yarn error

* fix yarn

Author: pajaydev

.eslintrc

@@ -1,4 +1,4 @@
 language: node_js
 node_js:
-  - "6"
-  - "8.10.0"
+  - '6'
+  - '8.10.0'

.travis.yml

@@ -16,5 +16,5 @@ Once you completed making the change, Please make sure to run the tests before y
 `npm run test` which will test your code.
 
 **Working on your first Pull Request?** 
-<a href="https://egghead.io/courses/how-to-contribute-to-an-open-source-project-on-github" target="_blank">How to Contribute to an Open Source Project on GitHub</a>.
+<a href='https://egghead.io/courses/how-to-contribute-to-an-open-source-project-on-github' target='_blank'>How to Contribute to an Open Source Project on GitHub</a>.
 Thanks to @kentcdodds for this amazing tutorial.

CONTRIBUTING.md

@@ -3,7 +3,7 @@ MIT License
 Copyright (c) 2018 Ajaykumar
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
+of this software and associated documentation files (the 'Software'), to deal
 in the Software without restriction, including without limitation the rights
 to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 copies of the Software, and to permit persons to whom the Software is
@@ -12,7 +12,7 @@ furnished to do so, subject to the following conditions:
 The above copyright notice and this permission notice shall be included in all
 copies or substantial portions of the Software.
 
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER

LICENSE

@@ -48,9 +48,9 @@ npm install ebay-node-api
 let eBay = require('ebay-node-api')
 
 let ebay = new eBay({
-    clientID: "-- Client APP ID ----",
+    clientID: '-- Client APP ID ----',
     // options  - optional HTTP request timeout to apply to all requests.
-    env: "SANDBOX" // optional default = "PRODUCTION"
+    env: 'SANDBOX' // optional default = 'PRODUCTION'
 })
 ```
 Creates a new `Ebay` instance.
@@ -74,13 +74,13 @@ If you using Sandbox environment, make sure to provide `env` variable in options
 ## GetAccessToken
 
 ```javascript
-const Ebay = require("ebay-node-api");
+const Ebay = require('ebay-node-api');
 
 let ebay = new Ebay({
-    clientID: "--Client Id----",
+    clientID: '--Client Id----',
     clientSecret: '-- Client Secret --',
     body: {
-        grant_type: "client_credentials",
+        grant_type: 'client_credentials',
 	//you may need to define the oauth scope
 	scope: 'https://api.ebay.com/oauth/api_scope'
     }
@@ -94,13 +94,13 @@ ebay.getAccessToken().then((data) => {
 
 ## FetchItemsByKeyword
 ```javascript
-const Ebay = require("ebay-node-api");
+const Ebay = require('ebay-node-api');
 
 let ebay = new Ebay({
-    clientID: "-- Client APP ID ----",
+    clientID: '-- Client APP ID ----',
     limit: 6
 });
-ebay.findItemsByKeywords("iphone").then((data) => {
+ebay.findItemsByKeywords('iphone').then((data) => {
     console.log(data); // fetches top 6 results in form of JSON.
 }, (error) => {
     console.log(error);
@@ -110,7 +110,7 @@ ebay.findItemsByKeywords("iphone").then((data) => {
 ## GetItemsByCategory
 ```javascript
 let ebay = new Ebay({
-    clientID: "-- Client APP ID ----",
+    clientID: '-- Client APP ID ----',
     limit: 6
 });
 ebay.findItemsByCategory(10181).then((data) => {
@@ -138,8 +138,8 @@ ebay.getAccessToken()
 ebay.getAccessToken()
     .then((data) => {
         ebay.getItemByLegacyId({
-            "legacyItemId": 2628001 // Get Item Details Using a Legacy ID
-            "legacyVariationSku": "V-00031-WHM" // default null
+            'legacyItemId': 2628001 // Get Item Details Using a Legacy ID
+            'legacyVariationSku': 'V-00031-WHM' // default null
         }).then((data) => {
             if (!data) console.log(data);
             // Data is in format of JSON
@@ -153,7 +153,7 @@ ebay.getAccessToken()
 ```javascript
 ebay.getAccessToken()
     .then((data) => {
-        ebay.getItemByItemGroup("151915076499").then((data) => {
+        ebay.getItemByItemGroup('151915076499').then((data) => {
             // Data is in format of JSON
             // To check the format of Data, Go to this url (https://jsonblob.com/56cbea67-30b8-11e8-953c-5d1886dcf4a0)
             console.log(data)
@@ -168,8 +168,8 @@ ebay.getAccessToken()
 ebay.getAccessToken()
     .then((data) => {
         ebay.searchItems({
-            keyword: "drone",
-            limit: "3"
+            keyword: 'drone',
+            limit: '3'
         }).then((data) => {
             console.log(data);
             // Data is in format of JSON
@@ -183,7 +183,7 @@ ebay.getAccessToken()
 ebay.getAccessToken()
     .then((data) => {
         ebay.searchItems({
-            keyword: "drone",
+            keyword: 'drone',
             limit: 3,
             // filter: { maxDeliveryCost: 0 } old object based filter method
 		  filter: 'maxDeliveryCost:0' // new string based filter method. Format here: https://developer.ebay.com/api-docs/buy/static/ref-buy-browse-filters.html#conditionIds
@@ -201,9 +201,9 @@ ebay.getAccessToken()
 ebay.getAccessToken()
     .then((data) => {
         ebay.searchItems({
-            keyword: "iphone",
+            keyword: 'iphone',
             limit: 3,
-            // filter: { price: "[300..800]", priceCurrency: "USD", conditions: "NEW" } old object based filter method
+            // filter: { price: '[300..800]', priceCurrency: 'USD', conditions: 'NEW' } old object based filter method
 		  filter: 'price:[300..800],priceCurrency:USD,conditions{NEW}' // new string based filter method. Format here: https://developer.ebay.com/api-docs/buy/static/ref-buy-browse-filters.html#conditionIds
         }).then((data) => {
             console.log(data);
@@ -221,7 +221,7 @@ ebay.getMostWatchedItems({
     categoryId: 267 // optional
 }).then((data) => {
     if (data.errorMessage) {
-        console.log("Error:" + data.errorMessage);
+        console.log('Error:' + data.errorMessage);
     }
     console.log(JSON.stringify(data));
 });
@@ -232,7 +232,7 @@ ebay.getSimilarItems({
     itemId=280254552262 // optional
 }).then((data) => {
     if (data.errorMessage) {
-        console.log("Error:" + data.errorMessage);
+        console.log('Error:' + data.errorMessage);
     }
     console.log(JSON.stringify(data));
     // JSON format of similar items.    
@@ -243,7 +243,7 @@ ebay.getSimilarItems({
 ```javascript
 ebay.getAccessToken()
     .then((data) => {
-        ebay.getDefaultCategoryTreeId("EBAY_US").then((data) => {
+        ebay.getDefaultCategoryTreeId('EBAY_US').then((data) => {
             console.log(data);
             // for EN_US { categoryTreeId: '0', categoryTreeVersion: '119' }    
         });
@@ -258,7 +258,7 @@ ebay.getAccessToken()
             // JSON format of complete category sub tree.    
         });
 
-        ebay.getCategorySuggestions(0, "iphone").then((data) => {
+        ebay.getCategorySuggestions(0, 'iphone').then((data) => {
             console.log(data);
             // JSON format of category suggestions.    
         });
@@ -280,23 +280,23 @@ ebay.getAllCategories('1234').then((data) => {
 
 // Get User Profile 
 //https://developer.ebay.com/devzone/shopping/docs/callref/GetUserProfile.html
-ebay.getUserDetails({ userId: "ajaykumapratha_0", details: true }).then((data) => {
+ebay.getUserDetails({ userId: 'ajaykumapratha_0', details: true }).then((data) => {
     console.log(data);
 }, (error) => {
     console.log(error);
 });
 
 // Get Item Status
 //https://developer.ebay.com/devzone/shopping/docs/callref/GetItemStatus.html
-ebay.getItemStatus(["153265274986", "153265274986"]).then((data) => {
+ebay.getItemStatus(['153265274986', '153265274986']).then((data) => {
     console.log(data);
 }, (error) => {
     console.log(error);
 });
 
 //https://developer.ebay.com/devzone/shopping/docs/callref/GetShippingCosts.html
 ebay.getShippingCosts({
-    itemId: "153265274986", destCountryCode: 'US',
+    itemId: '153265274986', destCountryCode: 'US',
     destPostalCode: '95128'
 }).then((data) => {
     console.log(data);

README.md

@@ -1,10 +1,12 @@
 const Ebay = require('../src/index');
-let access_token = "";
+const { clientId, clientSecret } = require('./credentials');
+
+let access_token = '';
 let ebay = new Ebay({
-    clientID: "-- Client ID -----",
-    clientSecret: '-- Client Secret---',
+    clientID: clientId,
+    clientSecret: clientSecret,
     body: {
-        grant_type: "client_credentials",
+        grant_type: 'client_credentials',
         scope: 'https://api.ebay.com/oauth/api_scope'
 
     }
@@ -26,7 +28,7 @@ ebay.getAccessToken()
 ebay.getAccessToken()
     .then((data) => {
         ebay.getItemByLegacyId({
-            "legacyItemId": 2628001 // Get Item Details Using a Legacy ID
+            'legacyItemId': 2628001 // Get Item Details Using a Legacy ID
         }).then((data) => {
             if (!data) console.log(data);
             // Data is in format of JSON
@@ -38,8 +40,8 @@ ebay.getAccessToken()
 ebay.getAccessToken()
     .then((data) => {
         ebay.getItemByLegacyId({
-            "legacyItemId": 2628001,
-            "legacyVariationSku": "V-00031-WHM"
+            'legacyItemId': 2628001,
+            'legacyVariationSku': 'V-00031-WHM'
         }).then((data) => {
             if (!data) console.log(data);
             // Data is in format of JSON
@@ -52,7 +54,7 @@ ebay.getAccessToken()
 // reference https://developer.ebay.com/api-docs/buy/browse/resources/item/methods/getItemsByItemGroup#uri.item_group_id
 ebay.getAccessToken()
     .then((data) => {
-        ebay.getItemByItemGroup("151915076499").then((data) => {
+        ebay.getItemByItemGroup('151915076499').then((data) => {
             // Data is in format of JSON
             // To check the format of Data, Go to this url (https://jsonblob.com/56cbea67-30b8-11e8-953c-5d1886dcf4a0)
             console.log(data)

demo/browseApi.js

@@ -0,0 +1,4 @@
+module.exports = {
+    clientId: "-- client id ----",
+    clientSecret: "--- client secret---"
+};

demo/credentials.js

@@ -1,15 +1,12 @@
 const Ebay = require('../src/index');
+const { clientId } = require('./credentials');
 
 let ebay = new Ebay({
-    clientID: "-- Client APP ID ----",
+    clientID: clientId,
     limit: 6
 });
 ebay.findItemsByCategory(10181).then((data) => {
     console.log(data);
 }, (error) => {
     console.log(error);
 });
-
-
-
-

demo/fetchItemsByCategory.js

@@ -1,10 +1,11 @@
 const Ebay = require('../src/index');
+const { clientId } = require('./credentials');
 
 let ebay = new Ebay({
-    clientID: "-- Client APP ID ----",
+    clientID: clientId,
     limit: 6
 });
-ebay.findItemsByKeywords("iphone").then((data) => {
+ebay.findItemsByKeywords('iphone').then((data) => {
     console.log(data);
 }, (error) => {
     console.log(error);

demo/fetchItemsByKeyword.js

@@ -1,11 +1,10 @@
-const Ebay = require('../src/index');
+const EbayToken = require('oauth-ebay');
+const { clientId, clientSecret } = require('./credentials');
 
-let ebay = new Ebay({
-    clientID: "--Client Id----",
-    clientSecret: '-- Client Secret --',
-    body: {
-        grant_type: "client_credentials"
-    }
+let ebay = new EbayToken({
+    clientID: clientId,
+    clientSecret: clientSecret,
+    grantType: 'client_credentials'
 });
 ebay.getAccessToken().then((data) => {
     console.log(data);