Bug fix (#21)

* using make-string for string conv

* included no-unused-vars eslint rule

Author: pajaydev

.eslintrc

@@ -18,6 +18,13 @@
         "no-trailing-spaces": 2,
         "space-unary-ops": 0,
         "no-unused-expressions": "off",
+        "no-unused-vars": [
+            "error",
+            {
+                "vars": "all",
+                "args": "after-used"
+            }
+        ],
         "no-new": "off",
         "no-console": "off",
         "no-shadow": "off",

demo/searchApi.js

@@ -1,7 +1,7 @@
 const Ebay = require('../src/index');
 let ebay = new Ebay({
-    clientID: "-- Client ID -----",
-    clientSecret: '-- Client Secret---',
+    clientID: "-- client id --",
+    clientSecret: '-- client secret ---',
     body: {
         grant_type: "client_credentials",
         scope: 'https://api.ebay.com/oauth/api_scope'
@@ -10,7 +10,7 @@ let ebay = new Ebay({
 });
 
 
-// Search for Items by Keyword.
+//Search for Items by Keyword.
 ebay.getAccessToken()
     .then((data) => {
         ebay.searchItems({
@@ -75,7 +75,7 @@ ebay.getAccessToken()
         ebay.searchItems({
             keyword: "iphone",
             limit: 3,
-            filter: { price: "[300..800]", priceCurrency: "USD", conditions: "NEW" }
+            filter: { price: "[300..800]", priceCurrency: "USD", conditions: "{NEW}" }
         }).then((data) => {
             console.log(data);
             // Data is in format of JSON

package.json

@@ -24,8 +24,9 @@
   "devDependencies": {
     "chai": "^4.1.2",
     "eslint": "^5.8.0",
+    "make-string": "^1.0.2",
     "mocha": "^5.0.1",
     "nock": "^9.2.3",
     "sinon": "^4.4.5"
   }
-}
+}

src/buy-api.js

@@ -1,4 +1,5 @@
-let { getRequest, makeRequest, base64Encode } = require('./request');
+const makeString = require('make-string');
+let { makeRequest } = require('./request');
 
 const getItem = function (itemId) {
     if (!itemId) throw new Error("Item Id is required");
@@ -37,6 +38,8 @@ const getItemByItemGroup = function (itemGroupId) {
     return new Promise((resolve, reject) => {
         makeRequest('api.ebay.com', `/buy/browse/v1/item/get_items_by_item_group?item_group_id=${itemGroupId}`, 'GET', this.options.body, auth).then((result) => {
             resolve(result);
+        }).then((error) => {
+            reject(error);
         });
     })
 };
@@ -51,12 +54,13 @@ const searchItems = function (searchConfig) {
     queryParam = queryParam + (searchConfig.categoryId ? "&category_ids=" + searchConfig.categoryId : '');
     queryParam = queryParam + (searchConfig.limit ? "&limit=" + searchConfig.limit : "");
     queryParam = queryParam + (searchConfig.sort ? "&sort=" + searchConfig.sort : "");
-    if (searchConfig.fieldgroups != undefined) queryParam = queryParam + "&fieldgroups=" + searchConfig.fieldgroups.toString();
-    if (searchConfig.filter != undefined) queryParam = queryParam + "&filter=" + encodeURIComponent(searchConfig.filter);
-    // console.log(queryParam);
+    if (searchConfig.fieldgroups != undefined) queryParam = queryParam + "&fieldgroups=" + searchConfig.fieldgroups;
+    if (searchConfig.filter != undefined) queryParam = queryParam + "&filter=" + encodeURIComponent(makeString(searchConfig.filter, { quotes: "no", braces: 'false' }));
     return new Promise((resolve, reject) => {
         makeRequest('api.ebay.com', `/buy/browse/v1/item_summary/search?${queryParam}`, 'GET', this.options.body, auth).then((result) => {
             resolve(result);
+        }).then((error) => {
+            reject(error);
         });
     });
 };

src/request.js

@@ -13,6 +13,10 @@ let getRequest = function getRequest(url) {
             res.on("end", () => {
                 resolve(body);
             });
+            res.on("error", (error) => {
+                reject(error);
+
+            });
         });
     })
 
@@ -43,6 +47,10 @@ let makeRequest = function postRequest(hostName, endpoint, methodName, data, tok
                 resolve(body);
 
             });
+            res.on("error", (error) => {
+                reject(error);
+
+            });
         });
         //console.log("request " + dataString);
         if (methodName == "POST") req.write(dataString)