chore: Fix failing CI jobs.

Fixes #377.

Author: pdeljanov

symphonia-codec-aac/src/aac/ics/tns.rs

@@ -167,8 +167,7 @@ impl Tns {
             for f in 0..self.n_filt[w] {
                 let top = bottom;
 
-                bottom =
-                    if top > self.coeffs[w][f].length { top - self.coeffs[w][f].length } else { 0 };
+                bottom = top.saturating_sub(self.coeffs[w][f].length);
 
                 let order = self.coeffs[w][f].order;
 

symphonia-core/src/audio.rs

@@ -340,7 +340,7 @@ impl<S: Sample> AudioBuffer<S> {
     /// Note: This is not a cheap operation for audio buffers with > 8 channels. It is advisable
     /// that this call is only used when operating on large batches of frames. Generally speaking,
     /// it is almost always better to use `chan()` to selectively choose the plane to read instead.
-    pub fn planes(&self) -> AudioPlanes<S> {
+    pub fn planes(&self) -> AudioPlanes<'_, S> {
         // Fill the audio planes structure with references to the written portion of each audio
         // plane.
         let mut planes = AudioPlanes::new(self.spec.channels);
@@ -358,7 +358,7 @@ impl<S: Sample> AudioBuffer<S> {
     /// that this call is only used when modifying large batches of frames. Generally speaking,
     /// it is almost always better to use `render()`, `fill()`, `chan_mut()`, and `chan_pair_mut()`
     /// to modify the buffer instead.
-    pub fn planes_mut(&mut self) -> AudioPlanesMut<S> {
+    pub fn planes_mut(&mut self) -> AudioPlanesMut<'_, S> {
         // Fill the audio planes structure with references to the written portion of each audio
         // plane.
         let mut planes = AudioPlanesMut::new(self.spec.channels);
@@ -472,13 +472,13 @@ impl AudioBufferRef<'_> {
 /// `AudioBufferRef`.
 pub trait AsAudioBufferRef {
     /// Get an `AudioBufferRef` reference.
-    fn as_audio_buffer_ref(&self) -> AudioBufferRef;
+    fn as_audio_buffer_ref(&self) -> AudioBufferRef<'_>;
 }
 
 macro_rules! impl_as_audio_buffer_ref {
     ($fmt:ty, $ref:path) => {
         impl AsAudioBufferRef for AudioBuffer<$fmt> {
-            fn as_audio_buffer_ref(&self) -> AudioBufferRef {
+            fn as_audio_buffer_ref(&self) -> AudioBufferRef<'_> {
                 $ref(Cow::Borrowed(self))
             }
         }

symphonia-core/src/codecs.rs

@@ -490,7 +490,7 @@ pub trait Decoder: Send + Sync {
     /// decoded audio buffer to change. All other errors are unrecoverable.
     ///
     /// Implementors of decoders *must* `clear` the internal buffer if an error occurs.
-    fn decode(&mut self, packet: &Packet) -> Result<AudioBufferRef>;
+    fn decode(&mut self, packet: &Packet) -> Result<AudioBufferRef<'_>>;
 
     /// Optionally, obtain post-decode information such as the verification status.
     fn finalize(&mut self) -> FinalizeResult;
@@ -500,7 +500,7 @@ pub trait Decoder: Send + Sync {
     /// After a successful call to `decode`, this will contain the audio content of the last decoded
     /// `Packet`. If the last call to `decode` resulted in an error, then implementors *must* ensure
     /// the returned audio buffer has zero length.
-    fn last_decoded(&self) -> AudioBufferRef;
+    fn last_decoded(&self) -> AudioBufferRef<'_>;
 }
 
 /// A `CodecDescriptor` stores a description of a single logical codec. Common information such as

symphonia-core/src/formats.rs

@@ -319,7 +319,7 @@ impl Packet {
     }
 
     /// Get a `BufStream` to read the packet data buffer sequentially.
-    pub fn as_buf_reader(&self) -> BufReader {
+    pub fn as_buf_reader(&self) -> BufReader<'_> {
         BufReader::new(&self.data)
     }
 }

symphonia-format-isomp4/src/atoms/alac.rs

@@ -11,6 +11,7 @@ use symphonia_core::io::ReadBytes;
 
 use crate::atoms::{Atom, AtomHeader};
 
+#[allow(dead_code)]
 #[derive(Debug)]
 pub struct AlacAtom {
     /// Atom header.

symphonia-format-isomp4/src/atoms/co64.rs

@@ -11,6 +11,7 @@ use symphonia_core::io::ReadBytes;
 use crate::atoms::{Atom, AtomHeader};
 
 /// Chunk offset atom (64-bit version).
+#[allow(dead_code)]
 #[derive(Debug)]
 pub struct Co64Atom {
     /// Atom header.

symphonia-format-isomp4/src/atoms/ctts.rs

@@ -11,6 +11,7 @@ use symphonia_core::io::ReadBytes;
 use crate::atoms::{Atom, AtomHeader};
 
 /// Composition time atom.
+#[allow(dead_code)]
 #[derive(Debug)]
 pub struct CttsAtom {
     /// Atom header.

symphonia-format-isomp4/src/atoms/esds.rs

@@ -38,6 +38,7 @@ fn read_descriptor_header<B: ReadBytes>(reader: &mut B) -> Result<(u8, u32)> {
     Ok((tag, size))
 }
 
+#[allow(dead_code)]
 #[derive(Debug)]
 pub struct EsdsAtom {
     /// Atom header.

symphonia-format-isomp4/src/atoms/flac.rs

@@ -13,6 +13,7 @@ use symphonia_utils_xiph::flac::metadata::{MetadataBlockHeader, MetadataBlockTyp
 
 use crate::atoms::{Atom, AtomHeader};
 
+#[allow(dead_code)]
 #[derive(Debug)]
 pub struct FlacAtom {
     /// Atom header.

symphonia-format-isomp4/src/atoms/ilst.rs

@@ -473,6 +473,7 @@ fn add_freeform_tag<B: ReadBytes>(
 }
 
 /// Metadata tag data atom.
+#[allow(dead_code)]
 pub struct MetaTagDataAtom {
     /// Atom header.
     header: AtomHeader,
@@ -515,6 +516,7 @@ impl Atom for MetaTagDataAtom {
 }
 
 /// Metadata tag name and mean atom.
+#[allow(dead_code)]
 pub struct MetaTagNamespaceAtom {
     /// Atom header.
     header: AtomHeader,
@@ -541,6 +543,7 @@ impl Atom for MetaTagNamespaceAtom {
 }
 
 /// A generic metadata tag atom.
+#[allow(dead_code)]
 pub struct MetaTagAtom {
     /// Atom header.
     header: AtomHeader,
@@ -606,6 +609,7 @@ impl Atom for MetaTagAtom {
 }
 
 /// User data atom.
+#[allow(dead_code)]
 pub struct IlstAtom {
     /// Atom header.
     header: AtomHeader,