ISSUE-338: retry test

Author: tatevikg1

tests/features/bootstrap/FeatureContext.php

@@ -1,17 +1,8 @@
 <?php
 
-use Behat\Behat\Context\Context;
 
 use Behat\Mink\Exception\ExpectationException;
 use Behat\MinkExtension\Context\MinkContext;
-#use Behat\MinkExtension\Context\RawMinkContext;
-
-//
-// Require 3rd-party libraries here:
-//
-//   require_once 'PHPUnit/Autoload.php';
-//   require_once 'PHPUnit/Framework/Assert/Functions.php';
-//
 
 /**
  * Features context.
@@ -107,7 +98,7 @@ public function spins($closure, $tries = 10)
                 $closure();
 
                 return;
-            } catch (\Exception $e) {
+            } catch (Exception $e) {
                 if ($i == $tries) {
                     throw $e;
                 }
@@ -179,7 +170,7 @@ public function isLoggedIn($throwsException = false)
     {
         $retVal = $this->token != null;
         if(!$retVal && $throwsException){
-            throw new \Exception('Not logged in yet');
+            throw new Exception('Not logged in yet');
         }
         return $retVal;
     }
@@ -325,4 +316,27 @@ public function iConfirmThePopup()
         $this->getSession()->getDriver()->getWebDriverSession()->accept_alert();
     }
 
+    /**
+     * @Then I must see :text
+     */
+    public function iShouldSee($text)
+    {
+        $maxAttempts = 3;
+        $waitTimeMs = 1000;
+
+        for ($attempt = 1; $attempt <= $maxAttempts; $attempt++) {
+            try {
+                $this->assertSession()->pageTextContains($this->fixStepArgument($text));
+                return;
+            } catch (\WebDriver\Exception\StaleElementReference $e) {
+                // Handle Selenium stale element exception, retry
+            } catch (\Behat\Mink\Exception\ResponseTextException $e) {
+                // Handle Mink text assertion failure, retry
+            }
+
+            usleep($waitTimeMs * 1000);
+        }
+
+        throw new Exception(sprintf("Text '%s' not found after %d attempts.", $text, $maxAttempts));
+    }
 }

tests/features/getting-started/menu.feature

@@ -7,7 +7,7 @@ Feature: Navigate the app using the menu
 
   Scenario Outline: Use main menu navigation links
     Given I have logged in as an administrator
-    Then I should see "<Pagename>"
+    Then I must see "<Pagename>"
     Examples:
       | Pagename                  |
       | dashboard                 |

tests/features/managing-campaigns/newcampaign.feature

@@ -9,26 +9,26 @@ Feature: Create new campaign
         Given I follow "Campaigns"
         Given I follow "Send a campaign"
         Given I follow "Start a new campaign"
-        Then I should see "Campaign subject"
+        Then I must see "Campaign subject"
         When I fill in "subject" with "This is a test subject"
         And I fill in "fromfield" with "From me me@mydomain.com"
         And I fill in "sendmethod" with "inputhere"
         And I fill in "message" with "This is the Content of the Campaign"
         And I fill in "footer" with "This is the Footer of the campaign"
         And I fill in "campaigntitle" with "This is the Title of the Campaign"
         And I press "Save and continue editing"
-        Then I should see "This is the Content of the Campaign"
+        Then I must see "This is the Content of the Campaign"
         When I follow "Scheduling"
-        Then I should see "Embargoed Until"
+        Then I must see "Embargoed Until"
         When I follow "Lists"
-        Then I should see "Please select the lists you want to send your campaign to"
-        And I should see "All Lists"
+        Then I must see "Please select the lists you want to send your campaign to"
+        And I must see "All Lists"
         When I check "targetlist[all]"
         And I press "Save and continue editing"
-        Then I should see "selected"
+        Then I must see "selected"
         When I follow "Finish"
         And I press "send"
-        Then I should see "Campaign queued"
+        Then I must see "Campaign queued"
 
     # Switch to using a scenario outline that tests subaccounts also
     Scenario: Select a list to send the campaign to
@@ -38,7 +38,7 @@ Feature: Create new campaign
         And I follow "Start a new campaign"
         When I follow "Lists"
         # Try with and without the colon
-        Then I should see "Please select the lists you want to send your campaign to:"
+        Then I must see "Please select the lists you want to send your campaign to:"
         And the "targetlist[all]" checkbox should not be checked
         And the "targetlist[allactive]" checkbox should not be checked