Callback interface (#5)

* test: implement unit tests

* feature: introduce callable interface

Author: Greg Bowler

src/CallbackTypeSafeGetter.php

@@ -0,0 +1,13 @@
+<?php
+namespace Gt\TypeSafeGetter;
+
+use DateTimeInterface;
+
+interface CallbackTypeSafeGetter {
+	public function get(string $name, ?callable $callback = null):mixed;
+	public function getString(string $name, ?callable $callback = null):?string;
+	public function getInt(string $name, ?callable $callback = null):?int;
+	public function getFloat(string $name, ?callable $callback = null):?float;
+	public function getBool(string $name, ?callable $callback = null):?bool;
+	public function getDateTime(string $name, ?callable $callback = null):?DateTimeInterface;
+}

src/NullableTypeSafeGetter.php

@@ -35,6 +35,16 @@ function(string|int|DateTimeInterface $value) {
 		);
 	}
 
+	/**
+	 * @template T
+	 * @param class-string<T> $className
+	 * @param string $name
+	 * @return T
+	 */
+	public function getClass(string $className, string $name):?object {
+		return new $className;
+	}
+
 	protected function getNullableType(string $name, string|callable $type):mixed {
 		$value = $this->get($name);
 		if(is_null($value)) {
@@ -59,16 +69,7 @@ protected function getNullableType(string $name, string|callable $type):mixed {
 			return call_user_func($type, $value);
 		}
 
-		$ucType = ucfirst($type);
-		if(class_exists($type)) {
-			return new $type($value);
-		}
-		elseif(method_exists($this, "get$ucType")) {
-			return call_user_func(
-				[$this, "get$ucType"],
-				$value
-			);
-		}
+
 
 		return null;
 	}

src/TypeSafeGetter.php

@@ -10,4 +10,4 @@ public function getInt(string $name):?int;
 	public function getFloat(string $name):?float;
 	public function getBool(string $name):?bool;
 	public function getDateTime(string $name):?DateTimeInterface;
-}
+}

test/phpunit/ExampleClass.php

@@ -0,0 +1,8 @@
+<?php
+namespace Gt\TypeSafeGetter\Test;
+
+class ExampleClass {
+	public function __construct(
+		public string $name
+	) {}
+}

test/phpunit/Example.php renamed to test/phpunit/TestGetter.php

@@ -1,9 +1,10 @@
 <?php
 namespace Gt\TypeSafeGetter\Test;
 
+use Gt\TypeSafeGetter\TypeSafeGetter;
 use Gt\TypeSafeGetter\NullableTypeSafeGetter;
 
-class Example {
+class TestGetter implements TypeSafeGetter {
 	use NullableTypeSafeGetter;
 
 	public function __construct(private array $kvp = []) {}

test/phpunit/TypeSafeGetterTest.php

@@ -7,72 +7,72 @@
 class TypeSafeGetterTest extends TestCase {
 	public function testGetString():void {
 		$value = uniqid();
-		$sut = new Example([
+		$sut = new TestGetter([
 			"test" => $value,
 		]);
 		self::assertSame($value, $sut->getString("test"));
 	}
 
 	public function testGetString_null():void {
-		$sut = new Example();
+		$sut = new TestGetter();
 		self::assertNull($sut->getString("test"));
 	}
 
 	public function testGetString_castFromInt():void {
-		$sut = new Example([
+		$sut = new TestGetter([
 			"test" => 123,
 		]);
 		self::assertSame("123", $sut->getString("test"));
 	}
 
 	public function testGetInt():void {
 		$value = rand(1, 999);
-		$sut = new Example([
+		$sut = new TestGetter([
 			"test" => $value,
 		]);
 		self::assertSame($value, $sut->getInt("test"));
 	}
 
 	public function testGetInt_null():void {
-		$sut = new Example();
+		$sut = new TestGetter();
 		self::assertNull($sut->getInt("test"));
 	}
 
 	public function testGetInt_castFromFloat():void {
 		$value = 123.456;
-		$sut = new Example([
+		$sut = new TestGetter([
 			"test" => $value,
 		]);
 		self::assertSame(123, $sut->getInt("test"));
 	}
 
 	public function testGetFloat():void {
 		$value = 123.456;
-		$sut = new Example([
+		$sut = new TestGetter([
 			"test" => $value,
 		]);
 		self::assertSame($value, $sut->getFloat("test"));
 	}
 
 	public function testGetFloat_null():void {
-		$sut = new Example();
+		$sut = new TestGetter();
 		self::assertNull($sut->getFloat("test"));
 	}
 
 	public function testGetBool():void {
-		$sut = new Example([
+		$sut = new TestGetter([
 			"test" => true,
 		]);
 		self::assertTrue($sut->getBool("test"));
 	}
 
 	public function testGetBool_null():void {
-		$sut = new Example();
+		$sut = new TestGetter();
 		self::assertNull($sut->getBool("test"));
 	}
 
 	public function testGetBool_castFromString():void {
-		$sut = new Example([
+		$sut = new TestGetter([
 			"yes" => "truthy",
 			"no" => "",
 		]);
@@ -82,20 +82,20 @@ public function testGetBool_castFromString():void {
 
 	public function testGetDateTime():void {
 		$value = new DateTime();
-		$sut = new Example([
+		$sut = new TestGetter([
 			"test" => $value,
 		]);
 		self::assertSame($value, $sut->getDateTime("test"));
 	}
 
 	public function testGetDateTime_null():void {
-		$sut = new Example();
+		$sut = new TestGetter();
 		self::assertNull($sut->getDateTime("test"));
 	}
 
 	public function testGetDateTime_castFromString():void {
 		$dateString = "1988-04-05";
-		$sut = new Example([
+		$sut = new TestGetter([
 			"test" => $dateString,
 		]);
 		$dateTime = $sut->getDateTime("test");
@@ -105,7 +105,7 @@ public function testGetDateTime_castFromString():void {
 	public function testGetDateTime_castFromInt():void {
 		$dateString = "1900-04-05";
 		$timestamp = strtotime($dateString);
-		$sut = new Example([
+		$sut = new TestGetter([
 			"test" => $timestamp,
 		]);
 		$dateTime = $sut->getDateTime("test");