Enable additional linters and fix reported issues

Author: Danielius1922

.github/workflows/staticAnalysis.yml

@@ -20,33 +20,12 @@ jobs:
       - name: Run go vet
         run: go vet ./...
 
-      - name: Install and run ineffassign
-        run: |
-          export PATH=${PATH}:`go env GOPATH`/bin
-          go install github.com/gordonklaus/ineffassign@latest
-          ineffassign ./...
-
-      - name: Install and run errcheck
-        run: |
-          export PATH=${PATH}:`go env GOPATH`/bin
-          go install github.com/kisielk/errcheck@latest
-          if errcheck ./... | grep -v 'example'; then\
-            exit 1;\
-          fi
-
       - name: Install and run gocyclo
         run: |
           export PATH=${PATH}:`go env GOPATH`/bin
           go install github.com/fzipp/gocyclo/cmd/gocyclo@latest
           gocyclo -over 15 -ignore ".pb(.gw)?.go$|_test.go$|wsproxy" . || echo "gocyclo detected too complex functions"
 
-      - name: Install and run misspell
-        run: |
-          # check misspelling in all files in repository
-          export PATH=${PATH}:`go env GOPATH`/bin
-          go install github.com/client9/misspell/cmd/misspell@latest
-          find . -type f -exec misspell {} \;
-
       # Disable aligncheck until it is compatible with golang v1.18
       # - name: Install and run aligncheck
       #   run: |

.golangci.yml

@@ -1,15 +1,8 @@
 linters-settings:
   govet:
-    # check-shadowing: true
-    check-shadowing: false
-  exhaustive:
-    default-signifies-exhaustive: true
-  gomodguard:
-    blocked:
-      modules:
-        - github.com/pkg/errors:
-            recommendations:
-            - errors
+    check-shadowing: true
+  gocyclo:
+    min-complexity: 15
 
 linters:
   enable:
@@ -22,7 +15,7 @@ linters:
     - depguard         # Go linter that checks if package imports are in a list of acceptable packages
     # - dogsled          # Checks assignments with too many blank identifiers (e.g. x, _, _, _, := f())
     # - dupl             # Tool for code clone detection
-    # - durationcheck    # check for two durations multiplied together
+    - durationcheck    # check for two durations multiplied together
     - errcheck         # Errcheck is a program for checking for unchecked errors in go programs. These unchecked errors can be critical bugs in some cases
     - errchkjson       # Checks types passed to the json encoding functions. Reports unsupported types and optionally reports occations, where the check for the returned error can be omitted.
     # - errname          # Checks that sentinel errors are prefixed with the `Err` and error types are suffixed with the `Error`.
@@ -31,7 +24,7 @@ linters:
     - exportloopref    # checks for pointers to enclosing loop variables
     # - forbidigo        # Forbids identifiers
     # - forcetypeassert  # finds forced type assertions
-    # - gci              # Gci control golang package import order and make it always deterministic.
+    - gci              # Gci control golang package import order and make it always deterministic.
     # - gochecknoglobals # Checks that no globals are present in Go code
     # - gochecknoinits   # Checks that no init functions are present in Go code
     # - gocognit         # Computes and checks the cognitive complexity of functions
@@ -69,7 +62,7 @@ linters:
     - typecheck        # Like the front-end of a Go compiler, parses and type-checks Go code
     - unconvert        # Remove unnecessary type conversions
     # - unparam          # Reports unused function parameters
-    # - unused           # Checks Go code for unused constants, variables, functions and types
+    - unused           # Checks Go code for unused constants, variables, functions and types
     - varcheck         # Finds unused global variables and constants
     # - wastedassign     # wastedassign finds wasted assignment statements
     - whitespace       # Tool for detection of leading and trailing whitespace