Fix issues reported by golangsci-lint

Author: Daniel Adam

dtls/client.go

@@ -80,7 +80,7 @@ func Client(conn *dtls.Conn, opts ...udp.Option) *udpClient.Conn {
 		errorsFunc(fmt.Errorf("dtls: %v: %w", conn.RemoteAddr(), err))
 	}
 
-	createBlockWise := func(cc *udpClient.Conn) *blockwise.BlockWise[*udpClient.Conn] {
+	createBlockWise := func(*udpClient.Conn) *blockwise.BlockWise[*udpClient.Conn] {
 		return nil
 	}
 	if cfg.BlockwiseEnable {

dtls/client_test.go

@@ -207,7 +207,7 @@ func TestConnGetSeparateMessage(t *testing.T) {
 		require.NoError(t, errS)
 	}()
 
-	cc, err := dtls.Dial(l.Addr().String(), dtlsCfg, options.WithHandlerFunc(func(w *responsewriter.ResponseWriter[*client.Conn], r *pool.Message) {
+	cc, err := dtls.Dial(l.Addr().String(), dtlsCfg, options.WithHandlerFunc(func(_ *responsewriter.ResponseWriter[*client.Conn], r *pool.Message) {
 		assert.NoError(t, fmt.Errorf("none msg expected comes: %+v", r))
 	}))
 	require.NoError(t, err)

dtls/server/config.go

@@ -20,7 +20,7 @@ type HandlerFunc = func(*responsewriter.ResponseWriter[*udpClient.Conn], *pool.M
 type ErrorFunc = func(error)
 
 // OnNewConnFunc is the callback for new connections.
-type OnNewConnFunc = func(cc *udpClient.Conn)
+type OnNewConnFunc = func(*udpClient.Conn)
 
 type GetMIDFunc = func() int32
 
@@ -34,10 +34,10 @@ var DefaultConfig = func() Config {
 			}
 			return inactivity.New(timeout, onInactive)
 		},
-		RequestMonitor: func(cc *udpClient.Conn, req *pool.Message) (bool, error) {
+		RequestMonitor: func(*udpClient.Conn, *pool.Message) (bool, error) {
 			return false, nil
 		},
-		OnNewConn: func(cc *udpClient.Conn) {
+		OnNewConn: func(*udpClient.Conn) {
 			// do nothing by default
 		},
 		TransmissionNStart:             1,
@@ -46,7 +46,7 @@ var DefaultConfig = func() Config {
 		GetMID:                         message.GetMID,
 		MTU:                            udpClient.DefaultMTU,
 	}
-	opts.Handler = func(w *responsewriter.ResponseWriter[*udpClient.Conn], r *pool.Message) {
+	opts.Handler = func(w *responsewriter.ResponseWriter[*udpClient.Conn], _ *pool.Message) {
 		if err := w.SetResponse(codes.NotFound, message.TextPlain, nil); err != nil {
 			opts.Errors(fmt.Errorf("dtls server: cannot set response: %w", err))
 		}

dtls/server/server.go

@@ -188,7 +188,7 @@ func (s *Server) Stop() {
 }
 
 func (s *Server) createConn(connection *coapNet.Conn, inactivityMonitor udpClient.InactivityMonitor, requestMonitor udpClient.RequestMonitorFunc) *udpClient.Conn {
-	createBlockWise := func(cc *udpClient.Conn) *blockwise.BlockWise[*udpClient.Conn] {
+	createBlockWise := func(*udpClient.Conn) *blockwise.BlockWise[*udpClient.Conn] {
 		return nil
 	}
 	if s.cfg.BlockwiseEnable {

message/codes/codes_test.go

@@ -93,7 +93,7 @@ func FuzzUnmarshalJSON(f *testing.F) {
 	f.Add([]byte("0x2a"))
 	f.Add([]byte("42"))
 
-	f.Fuzz(func(t *testing.T, input_data []byte) {
+	f.Fuzz(func(_ *testing.T, input_data []byte) {
 		var got Code
 		_ = got.UnmarshalJSON(input_data)
 	})

message/options_test.go

@@ -352,7 +352,7 @@ func TestQueryOption(t *testing.T) {
 }
 
 func FuzzUnmarshalData(f *testing.F) {
-	f.Fuzz(func(t *testing.T, input_data []byte) {
+	f.Fuzz(func(_ *testing.T, input_data []byte) {
 		uoptions := make(Options, 0, 10)
 		_, _ = uoptions.Unmarshal(input_data, CoapOptionDefs)
 	})

mux/example_logging_middleware_test.go

@@ -16,7 +16,7 @@ func loggingMiddleware(next mux.Handler) mux.Handler {
 
 func Example_authenticationMiddleware() {
 	r := mux.NewRouter()
-	r.HandleFunc("/", func(w mux.ResponseWriter, r *mux.Message) {
+	r.HandleFunc("/", func(mux.ResponseWriter, *mux.Message) {
 		// Do something here
 	})
 	r.Use(loggingMiddleware)

mux/router.go

@@ -74,7 +74,7 @@ func NewRouter() *Router {
 		m: new(sync.RWMutex),
 		z: make(map[string]Route),
 	}
-	router.defaultHandler = HandlerFunc(func(w ResponseWriter, m *Message) {
+	router.defaultHandler = HandlerFunc(func(w ResponseWriter, _ *Message) {
 		if err := w.SetResponse(codes.NotFound, message.TextPlain, nil); err != nil {
 			router.errors(fmt.Errorf("router handler: cannot set response: %w", err))
 		}

mux/router_test.go

@@ -111,7 +111,7 @@ func TestMux(t *testing.T) {
 
 	for _, test := range tests {
 		t.Run(test.title, func(t *testing.T) {
-			r.HandleFunc(test.pathTemplate, func(w mux.ResponseWriter, r *mux.Message) {})
+			r.HandleFunc(test.pathTemplate, func(mux.ResponseWriter, *mux.Message) {})
 			testRegexp(t, r, test)
 			testRoute(t, r, test)
 			err := r.HandleRemove(test.pathTemplate)

net/blockwise/blockwise.go

@@ -163,7 +163,7 @@ func New[C Client](
 	getSentRequestFromOutside func(token message.Token) (*pool.Message, bool),
 ) *BlockWise[C] {
 	if getSentRequestFromOutside == nil {
-		getSentRequestFromOutside = func(token message.Token) (*pool.Message, bool) { return nil, false }
+		getSentRequestFromOutside = func(message.Token) (*pool.Message, bool) { return nil, false }
 	}
 	return &BlockWise[C]{
 		cc:                        cc,