Skip to content

Commit c7536f8

Browse files
committed
run_qemu.sh: do not automatically modprobe 'cxl_test' at boot time
Boot time is not a good time to debug issues like pmem/ndctl#278 or any other really. `git -C ndctl/ grep 'modprobe.*cxl_test'` shows that pretty much every test already loads and unloads cxl_test by itself. If some exotic test managed to avoid doing this until today, then falling back in line is overdue. PS: the "depmod_load_..." variable names were wrong: this was relying on systemd, not depmod. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
1 parent 74708d1 commit c7536f8

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

run_qemu.sh

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1032,8 +1032,6 @@ setup_depmod()
10321032
depmod_dir="$prefix/etc/depmod.d"
10331033
depmod_conf="$depmod_dir/nfit_test.conf"
10341034
depmod_cxl_conf="$depmod_dir/cxl_test.conf"
1035-
depmod_load_dir="$prefix/etc/modules-load.d"
1036-
depmod_load_cxl_conf="$depmod_load_dir/cxl_test.conf"
10371035

10381036
if [[ $_arg_nfit_test == "on" ]]; then
10391037
mkdir -p "$depmod_dir"
@@ -1062,13 +1060,8 @@ setup_depmod()
10621060
override cxl_mem * extra
10631061
override cxl_port * extra
10641062
EOF
1065-
mkdir -p "$depmod_load_dir"
1066-
cat <<- EOF > "$depmod_load_cxl_conf"
1067-
cxl_test
1068-
EOF
10691063
else
10701064
rm -f "$depmod_cxl_conf"
1071-
rm -f "$depmod_load_cxl_conf"
10721065
fi
10731066
system_map="$prefix/boot/System.map"
10741067
if [ ! -f "$system_map" ]; then

0 commit comments

Comments
 (0)