CameraTargetInstruction: Use little-endian long for ActorUniqueId (#271)

nicholass003 · IvanCraft623 · web-flow · commit 440c8078c66c · 2024-09-18T15:58:42.000-05:00
thanks for the consistency mojang... :/
Co-authored-by: IvanCraft623 &lt;ivancraft623@gmail.com&gt;
diff --git a/src/types/camera/CameraTargetInstruction.php b/src/types/camera/CameraTargetInstruction.php
@@ -30,7 +30,7 @@ public function getActorUniqueId() : int{ return $this->actorUniqueId; }
 
 	public static function read(PacketSerializer $in) : self{
 		$targetCenterOffset = $in->readOptional(fn() => $in->getVector3());
-		$actorUniqueId = $in->getActorUniqueId();
+		$actorUniqueId = $in->getLLong(); //why be consistent mojang ?????
 		return new self(
 			$targetCenterOffset,
 			$actorUniqueId
@@ -39,6 +39,6 @@ public static function read(PacketSerializer $in) : self{
 
 	public function write(PacketSerializer $out) : void{
 		$out->writeOptional($this->targetCenterOffset, fn(Vector3 $v) => $out->putVector3($v));
-		$out->putActorUniqueId($this->actorUniqueId);
+		$out->putLLong($this->actorUniqueId);
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ public function getActorUniqueId() : int{ return $this->actorUniqueId; }`
`30`	`30`
`31`	`31`	`public static function read(PacketSerializer $in) : self{`
`32`	`32`	`$targetCenterOffset = $in->readOptional(fn() => $in->getVector3());`
`33`		`- $actorUniqueId = $in->getActorUniqueId();`
	`33`	`+ $actorUniqueId = $in->getLLong(); //why be consistent mojang ?????`
`34`	`34`	`return new self(`
`35`	`35`	`$targetCenterOffset,`
`36`	`36`	`$actorUniqueId`
`@@ -39,6 +39,6 @@ public static function read(PacketSerializer $in) : self{`
`39`	`39`
`40`	`40`	`public function write(PacketSerializer $out) : void{`
`41`	`41`	`$out->writeOptional($this->targetCenterOffset, fn(Vector3 $v) => $out->putVector3($v));`
`42`		`- $out->putActorUniqueId($this->actorUniqueId);`
	`42`	`+ $out->putLLong($this->actorUniqueId);`
`43`	`43`	`}`
`44`	`44`	`}`