Vector3: remove support for sidesArray() with keys

dktapps · dktapps · commit 670f525d5346 · 2024-12-03T20:43:48.000Z
this is no longer possible to support with the conversion of Facing to an enum
diff --git a/src/Vector3.php b/src/Vector3.php
@@ -184,8 +184,9 @@ public function sides(int $step = 1) : \Generator{
 	 *
 	 * @return Vector3[]
 	 */
-	public function sidesArray(bool $keys = false, int $step = 1) : array{
-		return iterator_to_array($this->sides($step), $keys);
+	public function sidesArray(int $step = 1) : array{
+		//we can't include keys since Facing is now an enum
+		return iterator_to_array($this->sides($step), preserve_keys: false);
 	}
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -184,8 +184,9 @@ public function sides(int $step = 1) : \Generator{`
`184`	`184`	`*`
`185`	`185`	`* @return Vector3[]`
`186`	`186`	`*/`
`187`		`- public function sidesArray(bool $keys = false, int $step = 1) : array{`
`188`		`- return iterator_to_array($this->sides($step), $keys);`
	`187`	`+ public function sidesArray(int $step = 1) : array{`
	`188`	`+ //we can't include keys since Facing is now an enum`
	`189`	`+ return iterator_to_array($this->sides($step), preserve_keys: false);`
`189`	`190`	`}`
`190`	`191`
`191`	`192`	`/**`