fix crash when parsing parameters out of order in sprintf

Update sprintf-help.pd

Author: porres

cyclone_objects/binaries/control/sprintf.c

@@ -516,7 +516,15 @@ static int sprintf_parsepattern(t_sprintf *x, char **patternp){
                 sprintf(errstring, "%s parameter not supported", (dotseen ? "precision" : "width"));
             break;
         }
-        else if(!strchr("-+ #\'", *ptr)){ // accepted flags
+        else if(strchr("-+ #", *ptr)){ // accepted flags
+            if(dotseen){
+                sprintf(errstring, "parameters out of order, flags come before precision field");
+                break;
+            }
+            else
+                continue;
+        }
+        else{
             if(x)
                 sprintf(errstring, "\'%c\' format character not supported", *ptr);
             break;

documentation/help_files/sprintf-help.pd

@@ -4,23 +4,23 @@
 #X obj 3 499 cnv 3 550 3 empty empty arguments 8 12 0 13 #dcdcdc #000000 0;
 #X obj 75 412 cnv 17 3 17 empty empty 0 5 9 0 16 #dcdcdc #9c9c9c 0;
 #X obj 75 475 cnv 17 3 17 empty empty 0 5 9 0 16 #dcdcdc #9c9c9c 0;
-#X obj 51 251 print;
+#X obj 51 281 print;
 #X obj 3 590 cnv 15 552 21 empty empty empty 20 12 0 14 #e0e0e0 #202020 0;
 #X text 173 507 -;
 #X text 115 475 anything;
-#X obj 21 186 bng 17 250 50 0 empty empty empty 17 7 0 10 #dcdcdc #000000 #000000;
+#X obj 21 201 bng 17 250 50 0 empty empty empty 17 7 0 10 #dcdcdc #000000 #000000;
 #X text 139 413 bang;
 #X text 115 436 anything;
 #X text 172 435 -;
 #X text 96 532 2) anything;
 #X text 108 507 1) symbol;
 #X text 173 532 -;
 #X text 185 507 the optional 'symout' argument formats a symbol message ('symout' itself not included), f 57;
-#X msg 198 186 wind;
-#X msg 51 186 wood;
+#X msg 198 201 wind;
+#X msg 51 201 wood;
 #X msg 272 163 64 64;
-#X obj 51 215 cyclone/sprintf %s-%s.wav;
-#X obj 318 163 nbx 3 14 -1e+37 1e+37 0 0 empty empty empty 0 -8 0 10 #dcdcdc #000000 #000000 0 256;
+#X obj 51 240 cyclone/sprintf %s-%s.wav;
+#X obj 328 163 nbx 3 14 -1e+37 1e+37 0 0 empty empty empty 0 -8 0 10 #dcdcdc #000000 #000000 0 256;
 #X text 172 413 - formats the message with current input, f 59;
 #X obj 75 434 cnv 17 3 27 empty empty 0-n 5 9 0 16 #dcdcdc #9c9c9c 0;
 #N canvas 749 189 489 533 possible-types 0;
@@ -60,7 +60,7 @@
 #X text 112 42 float hexadecimal in lowercase, f 49;
 #X text 112 54 float hexadecimal in CAPS, f 49;
 #X text 137 320 The above reference has more information and parameters not really available for [sprintf]. Nonetheless \, the length modifiers \, the optional flags: "+" \, " " \, "-" and "#" \, plus the width and precision fields are supported., f 47;
-#X text 35 387 Inconsistencies: If a format type is not supported or invalid \, [sprintf] doesn't create a corresponding inlet and prints an error isntead. The Max version creates an inlet for whatever inserted type \, invalid or not \, and only prints an error when trying to convert. The MAX original also doesn't support the "space" flag or %a/%A types. The length modifiers are supported but since Pd does not have an integer type \, something like '%ld' won't work with full precision even if you're using Pd compiled for double precision (aka Pd64). Also \, some values \, will only actually be possible to represent in Pd64., f 64;
+#X text 35 387 Inconsistencies: If a format type is not supported or invalid \, [sprintf] doesn't create a corresponding inlet and prints an error isntead. The Max version creates an inlet for whatever inserted type \, invalid or not \, and only prints an error when trying to convert. The MAX original also doesn't support the "space" flag or %a/%A types. The length modifiers are supported but since Pd does not have an integer type \, something like '%lld' won't work with full precision even if you're using Pd compiled for double precision (aka Pd64). Also \, some values for a format like '%u' will only actually be possible to represent in Pd64 because they can exceed the 2ˆ24 limit of 32-bit float., f 64;
 #X connect 20 0 19 0;
 #X connect 30 0 20 0;
 #X restore 335 562 pd possible-types;
@@ -78,8 +78,8 @@
 #X text 75 87 Based on C's "printf" function \, [sprintf] formats messages \, where each '%' format type corresponds to an inlet. By default you have each argument as a separate element in a message \, but the 'symout' argument creates a symbol out of everything., f 66;
 #X text 172 475 - the formatted message as a series of atoms or a symbol;
 #X text 153 349 Plugdata users or those with ELSE can also use [else/format] as an alternative., f 42;
-#X obj 249 163 bng 17 250 50 0 empty empty empty 17 7 0 10 #dcdcdc #000000 #000000;
-#X obj 318 190 trigger float float;
+#X obj 239 163 bng 17 250 50 0 empty empty empty 17 7 0 10 #dcdcdc #000000 #000000;
+#X obj 328 190 trigger float float;
 #N canvas 631 78 781 745 more 0;
 #X obj 61 276 print;
 #X obj 61 181 nbx 5 14 -1e+37 1e+37 0 0 empty empty empty 0 -8 0 10 #dcdcdc #000000 #000000 0 256;
@@ -119,16 +119,16 @@
 #X text 76 647 for more details on supported specifiers \, as most of them are shared between the two objects., f 21;
 #X text 76 602 See the help file of, f 12;
 #X obj 456 453 bng 19 250 50 0 empty empty empty 0 -8 0 10 #dfdfdf #000000 #000000;
-#X listbox 456 546 21 0 0 0 - - - 12;
-#X text 421 576 * The correct exact result is only possible in Pd compiled with double precision (aka Pd64), f 48;
-#X text 610 548 *;
+#X listbox 456 546 13 0 0 0 - - - 12;
+#X text 560 548 *;
 #X obj 456 512 cyclone/sprintf symout %u;
 #X text 21 16 The arguments in [sprintf] format a message to be sent out and can be floats and symbols with or without changeable arguments (like %i for integers \, %f for floats and %s for symbol strings) resembling the C programming language. The number of changeable arguments determines the number of inlets \, with each inlet corresponding to a changeable argument \, in order., f 64;
 #X text 35 514 Messages with more than one item spreads items to the next inlets., f 23;
 #X text 434 20 The optional 'symout' argument turns the whole output into a symbol message \, which is useful for format strings with spaces \, commas and other special characters. In this case you should not use backslash \, as it is common in Pd to escape a space or another special symbol., f 48;
 #X text 452 241 Nonetheless \, note you can use backslashes to create symbols with special characters such as spaces without the 'symout' argument., f 44;
-#X obj 456 483 expr pow(2 \, 32) - 1;
 #X text 281 643 The MAX original has issues in dealing with spaces for symbol input that contains spaces. Similarly \, there are also issues with the width field when it adds spaces and the 'space' flag. What happens is that atoms get split by the spaces when you don't have the 'symout' argument. The cyclone version also has the same issues., f 72;
+#X obj 456 483 expr pow(2 \, 32) - 2;
+#X text 421 576 * The correct exact result ('4294967294') is only possible in Pd compiled with double precision (aka Pd64), f 43;
 #X connect 1 0 34 0;
 #X connect 3 0 8 0;
 #X connect 4 0 6 0;
@@ -154,9 +154,10 @@
 #X connect 32 0 31 1;
 #X connect 34 0 0 0;
 #X connect 37 0 46 0;
-#X connect 41 0 38 0;
-#X connect 46 0 41 0;
-#X restore 222 295 pd more examples;
+#X connect 40 0 38 0;
+#X connect 46 0 40 0;
+#X restore 387 295 pd more examples;
+#X obj 272 281 print;
 #X connect 9 0 20 0;
 #X connect 17 0 20 1;
 #X connect 18 0 20 0;
@@ -165,6 +166,7 @@
 #X connect 21 0 40 0;
 #X connect 32 0 29 0;
 #X connect 34 0 35 0;
+#X connect 35 0 42 0;
 #X connect 39 0 34 0;
 #X connect 40 0 34 0;
 #X connect 40 1 34 1;