Skip to content

Commit 97786cd

Browse files
committed
Fix build by disabling mpg123 and libflac
1 parent 5a16446 commit 97786cd

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

External/build.sh

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,13 @@ run_cmake SDL_ttf ${OUTPUT_LIB/variant/_ttf} -DCMAKE_PREFIX_PATH=$CMAKE_PREFIX_P
173173
# TODO: Add support for avif on windows (VisualC script uses dynamic imports)
174174
run_cmake SDL_image ${OUTPUT_LIB/variant/_image} -DCMAKE_PREFIX_PATH=$CMAKE_PREFIX_PATH -DSDLIMAGE_AVIF=OFF -DSDLIMAGE_DEPS_SHARED=OFF -DSDLIMAGE_VENDORED=ON
175175

176-
run_cmake SDL_mixer ${OUTPUT_LIB/variant/_mixer} -DCMAKE_PREFIX_PATH=$CMAKE_PREFIX_PATH -DSDLMIXER_DEPS_SHARED=OFF -DSDLMIXER_VENDORED=ON
176+
# -DSDLMIXER_MP3_MPG123=OFF is used because upstream build is broken. Fallback to dr_mp3.
177+
# See: https://github.com/libsdl-org/SDL_mixer/pull/744#issuecomment-3180682130
178+
# Fixing using the proposed solution causes more issues.
179+
# Falls back to dr_mp3.
180+
#
181+
# -DSDLMIXER_FLAC_LIBFLAC is used because the build fails on android-x86. Fallback to drflac.
182+
# See: https://github.com/libsdl-org/SDL_mixer/issues/745
183+
run_cmake SDL_mixer ${OUTPUT_LIB/variant/_mixer} -DCMAKE_PREFIX_PATH=$CMAKE_PREFIX_PATH -DSDLMIXER_MP3_MPG123=OFF -DSDLMIXER_FLAC_LIBFLAC=OFF -DSDLMIXER_DEPS_SHARED=OFF -DSDLMIXER_VENDORED=ON
177184

178185
popd

0 commit comments

Comments
 (0)