Skip to content

Commit 35e389f

Browse files
CTMBNaraddubyk
CTMBNara
and
ddubyk
authored
Rubicon: No longer copy certain FPD fields (#3919)
Co-authored-by: ddubyk <ddubyk@magnite.com>
1 parent b2023fd commit 35e389f

14 files changed

+0
-100
lines changed

‎adapters/rubicon/rubicon.go

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -646,21 +646,9 @@ func (a *RubiconAdapter) updateImpRpTarget(extImp rubiconExtImpBidder, extImpRub
646646
if err != nil {
647647
return nil, err
648648
}
649-
if len(site.SectionCat) > 0 {
650-
addStringArrayAttribute(site.SectionCat, target, "sectioncat")
651-
}
652-
if len(site.PageCat) > 0 {
653-
addStringArrayAttribute(site.PageCat, target, "pagecat")
654-
}
655649
if site.Page != "" {
656650
addStringAttribute(site.Page, target, "page")
657651
}
658-
if site.Ref != "" {
659-
addStringAttribute(site.Ref, target, "ref")
660-
}
661-
if site.Search != "" {
662-
addStringAttribute(site.Search, target, "search")
663-
}
664652
} else {
665653
appExtData, _, _, err := jsonparser.Get(app.Ext, "data")
666654
if isNotKeyPathError(err) {
@@ -670,12 +658,6 @@ func (a *RubiconAdapter) updateImpRpTarget(extImp rubiconExtImpBidder, extImpRub
670658
if err != nil {
671659
return nil, err
672660
}
673-
if len(app.SectionCat) > 0 {
674-
addStringArrayAttribute(app.SectionCat, target, "sectioncat")
675-
}
676-
if len(app.PageCat) > 0 {
677-
addStringArrayAttribute(app.PageCat, target, "pagecat")
678-
}
679661
}
680662

681663
if len(extImp.Context.Data) > 0 {

‎adapters/rubicon/rubicontest/exemplary/25-26-transition-period.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -361,10 +361,6 @@
361361
"rp": {
362362
"target": {
363363
"pbadslot": "pbadslot",
364-
"pagecat": [
365-
"val1",
366-
"val2"
367-
],
368364
"pbs_login": "xuser",
369365
"pbs_url": "http://hosturl.com",
370366
"pbs_version": ""

‎adapters/rubicon/rubicontest/exemplary/app-imp-fpd.json

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -341,14 +341,6 @@
341341
"attr5": [
342342
"3"
343343
],
344-
"pagecat": [
345-
"val1",
346-
"val2"
347-
],
348-
"sectioncat": [
349-
"sectionCat1",
350-
"sectionCat2"
351-
],
352344
"pbs_login": "xuser",
353345
"pbs_url": "http://hosturl.com",
354346
"pbs_version": ""

‎adapters/rubicon/rubicontest/exemplary/bidonmultiformat.json

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -101,12 +101,6 @@
101101
"page": [
102102
"somePage"
103103
],
104-
"ref": [
105-
"someRef"
106-
],
107-
"search": [
108-
"someSearch"
109-
],
110104
"pbs_login": "xuser",
111105
"pbs_url": "http://hosturl.com",
112106
"pbs_version": ""
@@ -210,12 +204,6 @@
210204
"page": [
211205
"somePage"
212206
],
213-
"ref": [
214-
"someRef"
215-
],
216-
"search": [
217-
"someSearch"
218-
],
219207
"pbs_login": "xuser",
220208
"pbs_url": "http://hosturl.com",
221209
"pbs_version": ""

‎adapters/rubicon/rubicontest/exemplary/flexible-schema.json

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -341,14 +341,6 @@
341341
"attr5": [
342342
"3"
343343
],
344-
"pagecat": [
345-
"val1",
346-
"val2"
347-
],
348-
"sectioncat": [
349-
"sectionCat1",
350-
"sectionCat2"
351-
],
352344
"pbs_login": "xuser",
353345
"pbs_url": "http://hosturl.com",
354346
"pbs_version": ""

‎adapters/rubicon/rubicontest/exemplary/hardcode-secure.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -319,10 +319,6 @@
319319
"rp": {
320320
"target": {
321321
"pbadslot": "pbadslot",
322-
"pagecat": [
323-
"val1",
324-
"val2"
325-
],
326322
"pbs_login": "xuser",
327323
"pbs_url": "http://hosturl.com",
328324
"pbs_version": ""

‎adapters/rubicon/rubicontest/exemplary/non-bidonmultiformat.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -100,12 +100,6 @@
100100
"page": [
101101
"somePage"
102102
],
103-
"ref": [
104-
"someRef"
105-
],
106-
"search": [
107-
"someSearch"
108-
],
109103
"pbs_login": "xuser",
110104
"pbs_url": "http://hosturl.com",
111105
"pbs_version": ""

‎adapters/rubicon/rubicontest/exemplary/simple-banner.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -320,10 +320,6 @@
320320
"rp": {
321321
"target": {
322322
"pbadslot": "pbadslot",
323-
"pagecat": [
324-
"val1",
325-
"val2"
326-
],
327323
"pbs_login": "xuser",
328324
"pbs_url": "http://hosturl.com",
329325
"pbs_version": ""

‎adapters/rubicon/rubicontest/exemplary/simple-native.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -304,10 +304,6 @@
304304
"rp": {
305305
"target": {
306306
"pbadslot": "pbadslot",
307-
"pagecat": [
308-
"val1",
309-
"val2"
310-
],
311307
"pbs_login": "xuser",
312308
"pbs_url": "http://hosturl.com",
313309
"pbs_version": ""

‎adapters/rubicon/rubicontest/exemplary/simple-video.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -320,10 +320,6 @@
320320
"rp": {
321321
"target": {
322322
"pbadslot": "pbadslot",
323-
"pagecat": [
324-
"val1",
325-
"val2"
326-
],
327323
"pbs_login": "xuser",
328324
"pbs_url": "http://hosturl.com",
329325
"pbs_version": ""

0 commit comments

Comments
 (0)