Onetag: imp.ext read generalization (#4446)

EmanueleSimonelli · l-baglini · web-flow · commit bd3f8d5759bb · 2025-08-25T15:45:54.000-04:00
Co-authored-by: lorenzob &lt;l.baglini@onetag.com&gt;
diff --git a/adapters/onetag/onetag.go b/adapters/onetag/onetag.go
@@ -34,7 +34,7 @@ func Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server co
 
 func (a *adapter) MakeRequests(request *openrtb2.BidRequest, requestInfo *adapters.ExtraRequestInfo) ([]*adapters.RequestData, []error) {
 	pubID := ""
-	for idx, imp := range request.Imp {
+	for _, imp := range request.Imp {
 		onetagExt, err := getImpressionExt(imp)
 		if err != nil {
 			return nil, []error{err}
@@ -52,7 +52,6 @@ func (a *adapter) MakeRequests(request *openrtb2.BidRequest, requestInfo *adapte
 				Message: "The publisher ID must not be empty",
 			}}
 		}
-		request.Imp[idx].Ext = onetagExt.Ext
 	}
 
 	url, err := a.buildEndpointURL(pubID)
diff --git a/adapters/onetag/onetagtest/exemplary/no-bid.json b/adapters/onetag/onetagtest/exemplary/no-bid.json
@@ -63,6 +63,11 @@
                   ],
                   "w": 1024,
                   "h": 576
+                },
+                "ext": {
+                  "bidder": {
+                    "pubId": "386276e072"
+                  }
                 }
               }
             ]
diff --git a/adapters/onetag/onetagtest/exemplary/simple-banner.json b/adapters/onetag/onetagtest/exemplary/simple-banner.json
@@ -74,7 +74,12 @@
                  "w": 300,
                  "pos": 1
                },
-               "bidfloor": 0.05
+               "bidfloor": 0.05,
+               "ext": {
+                 "bidder": {
+                   "pubId": "386276e072"
+                 }
+               }
              },
              {
                "id": "121-dt2",
@@ -85,8 +90,13 @@
                },
                "bidfloor": 0.12,
                "ext": {
-                  "key1": "value1",
-                  "key2": "value2"
+                 "bidder": {
+                   "pubId": "386276e072",
+                   "ext": {
+                     "key1": "value1",
+                     "key2": "value2"
+                   }
+                 }
                }
              }
            ],
diff --git a/adapters/onetag/onetagtest/exemplary/simple-native.json b/adapters/onetag/onetagtest/exemplary/simple-native.json
@@ -56,7 +56,12 @@
                       "request":"{\"adunit\":2,\"assets\":[{\"id\":3,\"img\":{\"h\":120,\"hmin\":0,\"type\":3,\"w\":180,\"wmin\":0},\"required\":1},{\"id\":0,\"required\":1,\"title\":{\"len\":25}},{\"data\":{\"len\":25,\"type\":1},\"id\":4,\"required\":1},{\"data\":{\"len\":140,\"type\":2},\"id\":6,\"required\":1}],\"context\":1,\"layout\":1,\"contextsubtype\":11,\"plcmtcnt\":1,\"plcmttype\":2,\"ver\":\"1.1\",\"ext\":{\"banner\":{\"w\":320,\"h\":50}}}"
                   },
                   "ext": {
-                    "key1": "value1"
+                    "bidder": {
+                      "pubId": "386276e072",
+                      "ext": {
+                        "key1": "value1"
+                      }
+                    }
                   }
                 }
               ],
diff --git a/adapters/onetag/onetagtest/exemplary/simple-video.json b/adapters/onetag/onetagtest/exemplary/simple-video.json
@@ -63,6 +63,11 @@
                   ],
                   "w": 1024,
                   "h": 576
+                },
+                "ext": {
+                  "bidder": {
+                    "pubId": "386276e072"
+                  }
                 }
               }
             ]
diff --git a/adapters/onetag/onetagtest/exemplary/with-gpid.json b/adapters/onetag/onetagtest/exemplary/with-gpid.json
@@ -0,0 +1,67 @@
+{
+  "mockBidRequest": {
+    "id": "test-request-id",
+    "imp": [
+      {
+        "id": "test-imp-id",
+        "banner": {
+          "format": [
+            {
+              "w": 300,
+              "h": 250
+            }
+          ]
+        },
+        "ext": {
+          "gpid": "test-gpid",
+          "bidder": {
+            "pubId": "386276e072"
+          }
+        }
+      }
+    ],
+    "site": {
+      "id": "test-site-id"
+    }
+  },
+  "httpCalls": [
+    {
+      "expectedRequest": {
+        "uri": "https://example.com/prebid-server/386276e072",
+        "body": {
+          "id": "test-request-id",
+          "imp": [
+            {
+              "id": "test-imp-id",
+              "banner": {
+                "format": [
+                  {
+                    "w": 300,
+                    "h": 250
+                  }
+                ]
+              },
+              "ext": {
+                "gpid": "test-gpid",
+                "bidder": {
+                  "pubId": "386276e072"
+                }
+              }
+            }
+          ],
+          "site": {
+            "id": "test-site-id"
+          }
+        },
+        "impIDs": [
+          "test-imp-id"
+        ]
+      },
+      "mockResponse": {
+        "status": 204,
+        "body": {}
+      }
+    }
+  ],
+  "expectedBidResponses": []
+}
diff --git a/adapters/onetag/onetagtest/supplemental/internal-server-error.json b/adapters/onetag/onetagtest/supplemental/internal-server-error.json
@@ -63,6 +63,11 @@
                   ],
                   "w": 1024,
                   "h": 576
+                },
+                "ext": {
+                  "bidder": {
+                    "pubId": "386276e072"
+                  }
                 }
               }
             ]
diff --git a/adapters/onetag/onetagtest/supplemental/wrong-impression-id.json b/adapters/onetag/onetagtest/supplemental/wrong-impression-id.json
@@ -56,7 +56,12 @@
                     "w": 300,
                     "pos": 1
                   },
-                  "bidfloor": 0.05
+                  "bidfloor": 0.05,
+                  "ext": {
+                    "bidder": {
+                      "pubId": "386276e072"
+                    }
+                  }
                 }
             ],
             "site": {

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ func Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server co`
`34`	`34`
`35`	`35`	`func (a adapter) MakeRequests(request openrtb2.BidRequest, requestInfo adapters.ExtraRequestInfo) ([]adapters.RequestData, []error) {`
`36`	`36`	`pubID := ""`
`37`		`- for idx, imp := range request.Imp {`
	`37`	`+ for _, imp := range request.Imp {`
`38`	`38`	`onetagExt, err := getImpressionExt(imp)`
`39`	`39`	`if err != nil {`
`40`	`40`	`return nil, []error{err}`
`@@ -52,7 +52,6 @@ func (a adapter) MakeRequests(request openrtb2.BidRequest, requestInfo *adapte`
`52`	`52`	`Message: "The publisher ID must not be empty",`
`53`	`53`	`}}`
`54`	`54`	`}`
`55`		`- request.Imp[idx].Ext = onetagExt.Ext`
`56`	`55`	`}`
`57`	`56`
`58`	`57`	`url, err := a.buildEndpointURL(pubID)`
Original file line number	Diff line number	Diff line change
`@@ -63,6 +63,11 @@`
`63`	`63`	`],`
`64`	`64`	`"w": 1024,`
`65`	`65`	`"h": 576`
	`66`	`+ },`
	`67`	`+ "ext": {`
	`68`	`+ "bidder": {`
	`69`	`+ "pubId": "386276e072"`
	`70`	`+ }`
`66`	`71`	`}`
`67`	`72`	`}`
`68`	`73`	`]`
Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,12 @@`
`56`	`56`	`"request":"{\"adunit\":2,\"assets\":[{\"id\":3,\"img\":{\"h\":120,\"hmin\":0,\"type\":3,\"w\":180,\"wmin\":0},\"required\":1},{\"id\":0,\"required\":1,\"title\":{\"len\":25}},{\"data\":{\"len\":25,\"type\":1},\"id\":4,\"required\":1},{\"data\":{\"len\":140,\"type\":2},\"id\":6,\"required\":1}],\"context\":1,\"layout\":1,\"contextsubtype\":11,\"plcmtcnt\":1,\"plcmttype\":2,\"ver\":\"1.1\",\"ext\":{\"banner\":{\"w\":320,\"h\":50}}}"`
`57`	`57`	`},`
`58`	`58`	`"ext": {`
`59`		`- "key1": "value1"`
	`59`	`+ "bidder": {`
	`60`	`+ "pubId": "386276e072",`
	`61`	`+ "ext": {`
	`62`	`+ "key1": "value1"`
	`63`	`+ }`
	`64`	`+ }`
`60`	`65`	`}`
`61`	`66`	`}`
`62`	`67`	`],`