Skip to content

Commit ca0118c

Browse files
authored
Adnuntius: Copy advertiserDomains to ORTB bid response adomain (#4113)
1 parent 8b2b23e commit ca0118c

23 files changed

+35
-17
lines changed

adapters/adnuntius/adnuntius.go

Lines changed: 11 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -54,15 +54,16 @@ type Ad struct {
5454
GrossBid struct {
5555
Amount float64
5656
}
57-
DealID string `json:"dealId,omitempty"`
58-
AdId string
59-
CreativeWidth string
60-
CreativeHeight string
61-
CreativeId string
62-
LineItemId string
63-
Html string
64-
DestinationUrls map[string]string
65-
Advertiser adnAdvertiser `json:"advertiser,omitempty"`
57+
DealID string `json:"dealId,omitempty"`
58+
AdId string
59+
CreativeWidth string
60+
CreativeHeight string
61+
CreativeId string
62+
LineItemId string
63+
Html string
64+
DestinationUrls map[string]string
65+
AdvertiserDomains []string
66+
Advertiser adnAdvertiser `json:"advertiser,omitempty"`
6667
}
6768

6869
type AdUnit struct {
@@ -458,13 +459,6 @@ func generateAdResponse(ad Ad, imp openrtb2.Imp, html string, request *openrtb2.
458459
}}
459460
}
460461

461-
adDomain := []string{}
462-
for _, url := range ad.DestinationUrls {
463-
domainArray := strings.Split(url, "/")
464-
domain := strings.Replace(domainArray[2], "www.", "", -1)
465-
adDomain = append(adDomain, domain)
466-
}
467-
468462
bid := openrtb2.Bid{
469463
ID: ad.AdId,
470464
ImpID: imp.ID,
@@ -476,7 +470,7 @@ func generateAdResponse(ad Ad, imp openrtb2.Imp, html string, request *openrtb2.
476470
CrID: ad.CreativeId,
477471
Price: price * 1000,
478472
AdM: html,
479-
ADomain: adDomain,
473+
ADomain: ad.AdvertiserDomains,
480474
Ext: extJson,
481475
}
482476
return &bid, nil

adapters/adnuntius/adnuntiustest/exemplary/simple-banner.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@
5959
"destinationUrls": {
6060
"url": "http://www.google.com"
6161
},
62+
"advertiserDomains": ["google.com"],
6263
"bid": {
6364
"amount": 20.0,
6465
"currency": "NOK"

adapters/adnuntius/adnuntiustest/supplemental/check-dealId.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@
5959
"destinationUrls": {
6060
"url": "http://www.google.com"
6161
},
62+
"advertiserDomains": ["google.com"],
6263
"bid": {
6364
"amount": 20.0,
6465
"currency": "NOK"

adapters/adnuntius/adnuntiustest/supplemental/check-dsa-advertiser-legalName-omitted.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@
7878
"destinationUrls": {
7979
"url": "http://www.google.com"
8080
},
81+
"advertiserDomains": ["google.com"],
8182
"bid": {
8283
"amount": 20.0,
8384
"currency": "NOK"

adapters/adnuntius/adnuntiustest/supplemental/check-dsa-advertiser-legalName.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@
7878
"destinationUrls": {
7979
"url": "http://www.google.com"
8080
},
81+
"advertiserDomains": ["google.com"],
8182
"bid": {
8283
"amount": 20.0,
8384
"currency": "NOK"

adapters/adnuntius/adnuntiustest/supplemental/check-dsa-advertiser-omitted.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@
7878
"destinationUrls": {
7979
"url": "http://www.google.com"
8080
},
81+
"advertiserDomains": ["google.com"],
8182
"bid": {
8283
"amount": 20.0,
8384
"currency": "NOK"

adapters/adnuntius/adnuntiustest/supplemental/check-gdpr.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@
6868
"destinationUrls": {
6969
"url": "http://www.google.com"
7070
},
71+
"advertiserDomains": ["google.com"],
7172
"bid": {
7273
"amount": 20.0,
7374
"currency": "NOK"

adapters/adnuntius/adnuntiustest/supplemental/check-gross-bids.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@
6161
"destinationUrls": {
6262
"url": "http://www.google.com"
6363
},
64+
"advertiserDomains": ["google.com"],
6465
"bid": { "amount": 20.0, "currency": "NOK" },
6566
"grossBid": {"amount": 0.1, "currency": "NOK"},
6667
"netBid": {"amount": 0.075, "currency": "NOK"},

adapters/adnuntius/adnuntiustest/supplemental/check-net-bids.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@
6161
"destinationUrls": {
6262
"url": "http://www.google.com"
6363
},
64+
"advertiserDomains": ["google.com"],
6465
"bid": { "amount": 20.0, "currency": "NOK" },
6566
"grossBid": {"amount": 0.1, "currency": "NOK"},
6667
"netBid": {"amount": 0.075, "currency": "NOK"},

adapters/adnuntius/adnuntiustest/supplemental/check-noCookies-parameter.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@
6161
"destinationUrls": {
6262
"url": "http://www.google.com"
6363
},
64+
"advertiserDomains": ["google.com"],
6465
"bid": {
6566
"amount": 20.0,
6667
"currency": "NOK"

0 commit comments

Comments
 (0)