Report more information when a prebuild is not found

[aminya]

Currently, it is quite hard to understand why a prebuild is not picked up, especially when the log comes from the end user. I think adding a console.log that includes some information like the host's platform, architecture, libc, etc. will help debug the issues.

[vweevers]

We already do:

node-gyp-build/index.js

Lines 47 to 60 in 0078d78

	var target = [
	'platform=' + platform,
	'arch=' + arch,
	'runtime=' + runtime,
	'abi=' + abi,
	'uv=' + uv,
	armv ? 'armv=' + armv : '',
	'libc=' + libc,
	'node=' + process.versions.node,
	process.versions.electron ? 'electron=' + process.versions.electron : '',
	typeof __webpack_require__ === 'function' ? 'webpack=true' : '' // eslint-disable-line
	].filter(Boolean).join(' ')
	throw new Error('No native build was found for ' + target + '\n loaded from: ' + dir + '\n')

[aminya]

This is not happening when people run npm i. Some examples. See the logs.

zeromq/zeromq.js#526
zeromq/zeromq.js#530 (comment)

[vweevers]

I would guess because of https://github.com/zeromq/zeromq.js/blob/dd72eed5835e321e5c728959744e08f093557beb/package.json#L73 (the additional steps before node-gyp-build).

[aminya]

I added those just right now, and it is not released yet. Those reports are older.

[vweevers]

OK, may need npm i --verbose then. I don't recall.

[aminya]

Looking at the code, the code path is not clear to me. A lot of old-style JS dynamism and prototype assignment is used. Using TypeScript could make it easier to find the reason. Where is the call site of the load function?

node-gyp-build/index.js

Lines 18 to 25 in 0078d78

	module.exports = load
	function load (dir) {
	return runtimeRequire(load.path(dir))
	}
	load.path = function (dir) {

I also see some ignored error variables.

node-gyp-build/bin.js

Line 9 in 0078d78

if (err) {