ref: split criterion bench and RAM measure in provekit (#30)

Author: guorong009

provekit/Cargo.toml

@@ -9,6 +9,10 @@ utils = { workspace = true }
 criterion = { workspace = true }
 noir-r1cs = { git = "https://github.com/worldfnd/ProveKit", branch = "main" }
 
+[[bin]]
+name = "provekit-measure"
+path = "src/bin/measure.rs"
+
 [[bench]]
 name = "prove_verify"
 harness = false

provekit/README.md

@@ -8,3 +8,9 @@ This benchmark code is using the ProveKit of World Foundation(https://github.com
 ```bash
 cargo bench
 ```
+
+Measure RAM footprint:
+
+```bash
+cargo run -r --bin provekit-measure
+```

provekit/benches/prove_verify.rs

@@ -1,46 +1,10 @@
 use criterion::{BatchSize, Criterion, black_box, criterion_group, criterion_main};
-use provekit::{ProvekitSha256Benchmark, WORKSPACE_ROOT};
-use std::path::PathBuf;
-use utils::bench::{SubMetrics, display_submetrics, measure_peak_memory, write_json_submetrics};
+use provekit::ProvekitSha256Benchmark;
 
 const INPUT_EXPONENTS: [u32; 1] = [11];
 
 fn sha256_benchmarks(c: &mut Criterion) {
-    let (bench_harness, preprocessing_peak_memory) =
-        measure_peak_memory(|| ProvekitSha256Benchmark::new(&INPUT_EXPONENTS));
-
-    let mut all_metrics = Vec::new();
-
-    for &exp in INPUT_EXPONENTS.iter() {
-        let mut metrics = SubMetrics::new(1 << exp);
-        metrics.preprocessing_peak_memory = preprocessing_peak_memory;
-
-        let package_name = format!("sha256_bench_2e{exp}");
-        let circuit_path = PathBuf::from(WORKSPACE_ROOT)
-            .join("target")
-            .join(format!("{package_name}.json"));
-        let toml_path = PathBuf::from(WORKSPACE_ROOT)
-            .join("circuits/hash/sha256-provekit")
-            .join(format!("sha256-bench-2e{exp}"))
-            .join("Prover.toml");
-
-        metrics.preprocessing_size = std::fs::metadata(circuit_path)
-            .map(|m| m.len())
-            .unwrap_or(0) as usize
-            + std::fs::metadata(toml_path).map(|m| m.len()).unwrap_or(0) as usize;
-
-        let (proof, proving_peak_memory) = measure_peak_memory(|| bench_harness.run_prove(exp));
-        metrics.proving_peak_memory = proving_peak_memory;
-        metrics.proof_size = proof.whir_r1cs_proof.transcript.len();
-
-        all_metrics.push(metrics);
-    }
-
-    println!("{}", display_submetrics(&all_metrics));
-
-    let json_path = "sha2_provekit_submetrics.json";
-    write_json_submetrics(json_path, &all_metrics[0]);
-
+    let bench_harness = ProvekitSha256Benchmark::new(&INPUT_EXPONENTS);
     let mut group = c.benchmark_group("SHA256 Prove & Verify");
     group.sample_size(10);
 

provekit/src/bin/measure.rs

@@ -0,0 +1,47 @@
+use provekit::{ProvekitSha256Benchmark, WORKSPACE_ROOT};
+use std::path::PathBuf;
+use utils::bench::{SubMetrics, display_submetrics, measure_peak_memory, write_json_submetrics};
+
+const INPUT_EXPONENTS: [u32; 1] = [11];
+
+fn main() {
+    let metrics = benchmark_sha2();
+    let json_file: &'static str = "sha2_provekit_submetrics.json";
+    write_json_submetrics(json_file, &metrics[0]);
+}
+
+fn benchmark_sha2() -> Vec<SubMetrics> {
+    let (bench_harness, preprocessing_peak_memory) =
+        measure_peak_memory(|| ProvekitSha256Benchmark::new(&INPUT_EXPONENTS));
+
+    let mut all_metrics = Vec::new();
+
+    for &exp in INPUT_EXPONENTS.iter() {
+        let mut metrics = SubMetrics::new(1 << exp);
+        metrics.preprocessing_peak_memory = preprocessing_peak_memory;
+
+        let package_name = format!("sha256_bench_2e{exp}");
+        let circuit_path = PathBuf::from(WORKSPACE_ROOT)
+            .join("target")
+            .join(format!("{package_name}.json"));
+        let toml_path = PathBuf::from(WORKSPACE_ROOT)
+            .join("circuits/hash/sha256-provekit")
+            .join(format!("sha256-bench-2e{exp}"))
+            .join("Prover.toml");
+
+        metrics.preprocessing_size = std::fs::metadata(circuit_path)
+            .map(|m| m.len())
+            .unwrap_or(0) as usize
+            + std::fs::metadata(toml_path).map(|m| m.len()).unwrap_or(0) as usize;
+
+        let (proof, proving_peak_memory) = measure_peak_memory(|| bench_harness.run_prove(exp));
+        metrics.proving_peak_memory = proving_peak_memory;
+        metrics.proof_size = proof.whir_r1cs_proof.transcript.len();
+
+        all_metrics.push(metrics);
+    }
+
+    println!("{}", display_submetrics(&all_metrics));
+
+    all_metrics
+}