Skip to content

Commit 6363979

Browse files
committed
ci: remove useless matrix
1 parent 0e27730 commit 6363979

File tree

3 files changed

+29
-63
lines changed

3 files changed

+29
-63
lines changed

.github/workflows/ci.yml

Lines changed: 17 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,16 @@ on:
1111
merge_group:
1212
types: [checks_requested]
1313

14+
env:
15+
NODE_VERSION: 18
16+
1417
jobs:
1518
test:
16-
runs-on: ${{ matrix.os }}
19+
runs-on: ubuntu-latest
1720

1821
strategy:
1922
fail-fast: false
2023
matrix:
21-
os:
22-
- ubuntu-latest
2324
node-version:
2425
- 18
2526
- 20
@@ -57,20 +58,12 @@ jobs:
5758

5859
- name: Upload to Codecov
5960
uses: codecov/codecov-action@v4
60-
if: matrix.node-version == 18 && matrix.os == 'ubuntu-latest'
61+
if: matrix.node-version == 18
6162
with:
6263
fail_ci_if_error: false
6364

6465
lint:
65-
runs-on: ${{ matrix.os }}
66-
67-
strategy:
68-
fail-fast: false
69-
matrix:
70-
os:
71-
- ubuntu-latest
72-
node-version:
73-
- 18
66+
runs-on: ubuntu-latest
7467

7568
steps:
7669
- name: Git Checkout
@@ -91,10 +84,10 @@ jobs:
9184
restore-keys: |
9285
${{ runner.os }}-yarn-
9386
94-
- name: Use Node.js ${{ matrix.node-version }}
87+
- name: Use Node.js ${{ env.NODE_VERSION }}
9588
uses: actions/setup-node@v4
9689
with:
97-
node-version: ${{ matrix.node-version }}
90+
node-version: ${{ env.NODE_VERSION }}
9891
cache: "yarn"
9992

10093
- name: Install Deps
@@ -104,15 +97,7 @@ jobs:
10497
run: yarn lint:ci
10598

10699
typecheck:
107-
runs-on: ${{ matrix.os }}
108-
109-
strategy:
110-
fail-fast: false
111-
matrix:
112-
os:
113-
- ubuntu-latest
114-
node-version:
115-
- 18
100+
runs-on: ubuntu-latest
116101

117102
steps:
118103
- name: Git Checkout
@@ -133,10 +118,10 @@ jobs:
133118
restore-keys: |
134119
${{ runner.os }}-yarn-
135120
136-
- name: Use Node.js ${{ matrix.node-version }}
121+
- name: Use Node.js ${{ env.NODE_VERSION }}
137122
uses: actions/setup-node@v4
138123
with:
139-
node-version: ${{ matrix.node-version }}
124+
node-version: ${{ env.NODE_VERSION }}
140125
cache: "yarn"
141126

142127
- name: Install Deps
@@ -146,29 +131,21 @@ jobs:
146131
run: yarn typecheck
147132

148133
analyze:
149-
runs-on: ${{ matrix.os }}
134+
runs-on: ubuntu-latest
150135

151136
permissions:
152137
actions: read
153138
contents: read
154139
security-events: write
155140

156-
strategy:
157-
fail-fast: false
158-
matrix:
159-
os:
160-
- ubuntu-latest
161-
language:
162-
- javascript
163-
164141
steps:
165142
- name: Git Checkout
166143
uses: actions/checkout@v4
167144

168145
- name: Initialize CodeQL
169146
uses: github/codeql-action/init@v3
170147
with:
171-
languages: ${{ matrix.language }}
148+
languages: javascript
172149

173150
- name: Autobuild
174151
uses: github/codeql-action/autobuild@v3
@@ -183,15 +160,7 @@ jobs:
183160
- analyze
184161
- test
185162

186-
runs-on: ${{ matrix.os }}
187-
188-
strategy:
189-
fail-fast: false
190-
matrix:
191-
os:
192-
- ubuntu-latest
193-
node-version:
194-
- 18
163+
runs-on: ubuntu-latest
195164

196165
steps:
197166
- name: Git Checkout
@@ -212,10 +181,10 @@ jobs:
212181
restore-keys: |
213182
${{ runner.os }}-yarn-
214183
215-
- name: Use Node.js ${{ matrix.node-version }}
184+
- name: Use Node.js ${{ env.NODE_VERSION }}
216185
uses: actions/setup-node@v4
217186
with:
218-
node-version: ${{ matrix.node-version }}
187+
node-version: ${{ env.NODE_VERSION }}
219188
cache: "yarn"
220189

221190
- name: Install Deps
@@ -226,7 +195,7 @@ jobs:
226195

227196
- name: Deploy Docs
228197
uses: peaceiris/actions-gh-pages@v3
229-
if: matrix.node-version == 18 && github.ref == 'refs/heads/main'
198+
if: github.ref == 'refs/heads/main'
230199
with:
231200
github_token: ${{ secrets.GITHUB_TOKEN }}
232201
publish_dir: ./src/.vitepress/dist

.github/workflows/sync.yml

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,12 @@ permissions:
88
contents: write
99
pull-requests: write
1010

11+
env:
12+
NODE_VERSION: 18
13+
1114
jobs:
1215
test:
13-
runs-on: ${{ matrix.os }}
14-
15-
strategy:
16-
fail-fast: false
17-
matrix:
18-
os:
19-
- ubuntu-latest
20-
node-version:
21-
- 18
16+
runs-on: ubuntu-latest
2217

2318
steps:
2419
- name: Git Checkout
@@ -41,17 +36,17 @@ jobs:
4136
restore-keys: |
4237
${{ runner.os }}-yarn-
4338
44-
- name: Use Node.js ${{ matrix.node-version }}
39+
- name: Use Node.js ${{ env.NODE_VERSION }}
4540
uses: actions/setup-node@v4
4641
with:
47-
node-version: ${{ matrix.node-version }}
42+
node-version: ${{ env.NODE_VERSION }}
4843
cache: "yarn"
4944

5045
- name: Install Deps
5146
run: yarn install --immutable
5247

5348
- name: Run Sync
54-
run: yarn icon:sync
49+
run: yarn icon:sync && yarn ilustration:sync
5550
env:
5651
FIGMA_TOKEN: ${{ secrets.FIGMA_TOKEN }}
5752
FIGMA_FILE_ID: ${{ secrets.FIGMA_FILE_ID }}
@@ -61,5 +56,5 @@ jobs:
6156
with:
6257
token: ${{ secrets.PAT }}
6358
branch: feat/sync-icon
64-
commit-message: "chore(persona-icon): sync with figma"
65-
title: "chore(persona-icon): sync with figma"
59+
commit-message: "chore: sync with figma"
60+
title: "chore: sync with figma"

package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,9 @@
2323
"release": "yarn workspaces foreach -A -v --topological-dev --no-private npm publish --tolerate-republish",
2424
"release:prepare": "yarn workspaces foreach -A -v --topological-dev version",
2525
"icon:sync": "yarn workspace @privyid/persona-icon sync",
26-
"icon:changelog": "yarn workspace @privyid/persona-icon changelog"
26+
"icon:changelog": "yarn workspace @privyid/persona-icon changelog",
27+
"ilustration:sync": "yarn workspace @privyid/persona-ilustration sync",
28+
"ilustration:changelog": "yarn workspace @privyid/persona-ilustration changelog"
2729
},
2830
"devDependencies": {
2931
"@interactjs/types": "1.10.27",

0 commit comments

Comments
 (0)