Skip to content

Commit b416bbd

Browse files
authored
Merge pull request #644 from privy-open-source/fix/date-fns-on-prod
2 parents 4e9cccc + 10cb184 commit b416bbd

File tree

13 files changed

+382
-144
lines changed

13 files changed

+382
-144
lines changed

package.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@privyid/design-system",
3-
"version": "0.17.0",
3+
"version": "0.17.1",
44
"packageManager": "yarn@3.6.0",
55
"private": true,
66
"scripts": {
@@ -39,11 +39,11 @@
3939
"@testing-library/vue": "6.6.0",
4040
"@types/babel__core": "^7",
4141
"@types/babel__preset-env": "^7",
42-
"@types/lodash-es": "4.17.7",
42+
"@types/lodash-es": "4.17.8",
4343
"@types/marked": "^4",
4444
"@types/sanitize-html": "^2",
4545
"@types/scroll-into-view": "^1",
46-
"@types/testing-library__jest-dom": "5.14.6",
46+
"@types/testing-library__jest-dom": "5.14.8",
4747
"@types/webfontloader": "1.6.35",
4848
"@types/zxcvbn": "^4",
4949
"@typescript-eslint/eslint-plugin": "5.62.0",
@@ -73,10 +73,10 @@
7373
"nanodelay": "2.0.2",
7474
"postcss": "8.4.24",
7575
"postcss-nested": "6.0.1",
76-
"tailwindcss": "3.3.2",
77-
"typescript": "5.1.3",
76+
"tailwindcss": "3.3.3",
77+
"typescript": "5.1.6",
7878
"ufo": "^1.0.1",
79-
"vitepress": "1.0.0-beta.3",
79+
"vitepress": "1.0.0-beta.5",
8080
"vitest": "0.24.5",
8181
"vue-tsc": "1.4.4"
8282
},

packages/browserslist-config/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@privyid/browserslist-config",
33
"description": "Browserslist shareable config for Persona project",
4-
"version": "0.17.0",
4+
"version": "0.17.1",
55
"packageManager": "yarn@3.6.0",
66
"license": "MIT",
77
"repository": {

packages/eslint-config-persona/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@privyid/eslint-config-persona",
33
"description": "Eslint shareable config for Persona project",
4-
"version": "0.17.0",
4+
"version": "0.17.1",
55
"packageManager": "yarn@3.6.0",
66
"license": "MIT",
77
"repository": {

packages/persona-icon/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@privyid/persona-icon",
33
"description": "Persona icon package",
4-
"version": "0.17.0",
4+
"version": "0.17.1",
55
"packageManager": "yarn@3.6.0",
66
"type": "module",
77
"main": "./dist/module.cjs",

packages/persona/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@privyid/persona",
33
"description": "Persona core package",
4-
"version": "0.17.0",
4+
"version": "0.17.1",
55
"license": "MIT",
66
"repository": {
77
"url": "https://github.com/privy-open-source/design-system.git",

packages/persona/src/module.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export default defineNuxtModule<ModuleOptions>({
3131

3232
// Add alias to unsupported ESM package
3333
nuxt.options.alias['@carbon/icons-vue/lib'] = '@carbon/icons-vue/es'
34-
nuxt.options.alias['date-fns'] = 'date-fns/esm'
34+
nuxt.options.alias['date-fns/locale'] = 'date-fns/esm/locale'
3535

3636
// Add font CDN
3737
if (options.font) {

packages/tailwind-animation/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@privyid/tailwind-animation",
3-
"version": "0.17.0",
3+
"version": "0.17.1",
44
"packageManager": "yarn@3.6.0",
55
"license": "MIT",
66
"repository": {

packages/tailwind-extended/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@privyid/tailwind-extended",
33
"description": "Add missing tailwind utilities",
4-
"version": "0.17.0",
4+
"version": "0.17.1",
55
"packageManager": "yarn@3.6.0",
66
"license": "MIT",
77
"repository": {

packages/tailwind-preset/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@privyid/tailwind-preset",
33
"description": "Tailwind preset for Persona project",
4-
"version": "0.17.0",
4+
"version": "0.17.1",
55
"packageManager": "yarn@3.6.0",
66
"license": "MIT",
77
"repository": {

src/components/dropdown/Dropdown.vue

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333

3434
<Transition name="fade">
3535
<div
36-
v-show="isOpen"
36+
v-show="isOpen && !isHidden"
3737
ref="menu"
3838
data-testid="dropdown-menu"
3939
class="dropdown__menu"
@@ -57,6 +57,7 @@ import {
5757
toRef,
5858
watchEffect,
5959
computed,
60+
ref,
6061
} from 'vue-demi'
6162
import {
6263
templateRef,
@@ -73,6 +74,7 @@ import {
7374
offset,
7475
flip,
7576
shift,
77+
hide,
7678
} from '@floating-ui/dom'
7779
import { useVModel } from '../input'
7880
import IconArrow from '@carbon/icons-vue/lib/chevron--down/16'
@@ -175,6 +177,7 @@ export default defineComponent({
175177
const wizard = templateRef<DropdownSubitemElement>('wizard')
176178
const placement = toRef(props, 'placement')
177179
const isOpen = useVModel(props)
180+
const isHidden = ref(false)
178181
179182
const { next: nextFocus, prev: prevFocus } = useFocus(menu)
180183
@@ -280,13 +283,16 @@ export default defineComponent({
280283
flip(),
281284
shift(),
282285
offset(8),
286+
hide(),
283287
],
284-
}).then(({ x, y, placement }) => {
288+
}).then(({ x, y, placement, middlewareData }) => {
285289
if (menu.value) {
286290
menu.value.dataset.popperPlacement = placement
287291
288292
menu.value.style.left = `${x || 0}px`
289293
menu.value.style.top = `${y || 0}px`
294+
295+
isHidden.value = middlewareData.hide.referenceHidden
290296
}
291297
})
292298
})
@@ -309,6 +315,7 @@ export default defineComponent({
309315
310316
return {
311317
isOpen,
318+
isHidden,
312319
classNames,
313320
containerSize,
314321
toggle,
@@ -327,7 +334,7 @@ export default defineComponent({
327334
--p-dropdown-size-sm: 15rem; /* 240px */
328335
--p-dropdown-max-height: theme(spacing.64);
329336
330-
@apply relative inline-flex;
337+
@apply inline-flex;
331338
332339
&__menu {
333340
@apply max-h-[var(--p-dropdown-max-height)] border rounded bg-default z-[var(--p-dropdown-z-index)] border-default shadow-xl overflow-x-hidden overflow-y-auto absolute;

0 commit comments

Comments
 (0)