raise 404

Author: karppo

src/rasenmaeher_api/web/api/instructions/views.py

@@ -3,7 +3,7 @@
 from typing import cast, Optional
 import logging
 
-from fastapi import Depends, APIRouter, Request
+from fastapi import Depends, APIRouter, Request, HTTPException
 from libpvarki.schemas.product import UserCRUDRequest, UserInstructionFragment
 
 
@@ -71,8 +71,8 @@ async def get_product_instructions(request: Request, product: str, language: str
     endpoint_url = f"api/v1/instructions/{language}"
     response = await post_to_product(product, endpoint_url, user.dict(), InstructionData)
     if response is None:
-        LOGGER.error("post_to_product({}, {}): failed".format(product, endpoint_url))
-        # TODO: Raise a reasonable error instead
-        return None
+        _reason = f"Unable to get instructions for {product}"
+        LOGGER.error("{} : {}".format(request.url, _reason))
+        raise HTTPException(status_code=404, detail=_reason)
     response = cast(InstructionData, response)
     return response