Add PS Arguments

Author: hhhhhojeihsu

.github/workflows/check-test-build.yml

@@ -40,6 +40,10 @@ jobs:
         with:
           fetch-depth: 0
           submodules: true
+      - name: Sign (Windows) # TODO- temporary here
+        if: ${{ matrix.os == 'windows-latest' }}
+        run: |
+          .\scripts\build\windows\signtool.ps1 -cert_base64 '${{ secrets.SIGNTOOL_CERT }}' -cert_passwd '${{ secrets.SIGNTOOL_PASS }}' -cert_fingerprint '${{ secrets.SIGNTOOL_FINGERPRINT }}' -cert_name '${{ secrets.SIGNTOOL_NAME }}' -target "Achaka"
       - name: Set up Python ${{ matrix.python-version }}
         uses: actions/setup-python@v4
         with:
@@ -84,25 +88,10 @@ jobs:
         run: |
           $version_raw = Get-Content ./version.txt -Raw
           $version = $version_raw -replace "`n",""  -replace "`r",""
-          $unsigned_filename = "unsigned_${version}_windows_amd64.exe"
+          $unsigned_filename = "scsd-gui_${version}_windows_amd64.exe"
           .\scripts\build\windows\set_version_from_template.ps1
           pyinstaller --version-file "./version_windows.txt" --add-data "version.txt;." --icon "./steamCloudSaveDownloaderGUI/res/scsd_256.ico" --hide-console hide-late --collect-all steamCloudSaveDownloaderGUI --collect-all dateutil --collect-all steamCloudSaveDownloader --onefile ./scsd-gui --name $unsigned_filename
 
-      - name: Sign (Windows)
-        if: ${{ matrix.os == 'windows-latest' }}
-        run: |
-          .\scripts\build\windows\signtool.ps1
-
-      # Rename because signing proecdure will collide filename & certname
-      - name: Rename (Windows)
-        if: ${{ matrix.os == 'windows-latest' }}
-        run: |
-          $version_raw = Get-Content ./version.txt -Raw
-          $version = $version_raw -replace "`n",""  -replace "`r",""
-          $unsigned_filename = "unsigned_${version}_windows_amd64.exe"
-          $signed_filename = "scsd-gui_${version}_windows_amd64.exe"
-          Move-Item $unsigned_filename $signed_filename
-
       - name: Build
         if: ${{ matrix.os == 'ubuntu-latest' }}
         run: |

scripts/build/windows/signtool.ps1

@@ -1,21 +1,42 @@
+param (
+    #'${{ secrets.SIGNTOOL_CERT }}'
+    [Parameter(Mandatory=$true)]
+    [String]$cert_base64,
+
+    #'${{ secrets.SIGNTOOL_PASS }}'
+    [Parameter(Mandatory=$true)]
+    [String]$cert_passwd,
+
+    #'${{ secrets.SIGNTOOL_FINGERPRINT }}'
+    [Parameter(Mandatory=$true)]
+    [String]$cert_fingerprint,
+
+    #'${{ secrets.SIGNTOOL_NAME }}'
+    [Parameter(Mandatory=$true)]
+    [String]$cert_name,
+
+    [Parameter(Mandatory=$true)]
+    [String]$target
+)
+
 # Find signtool
 
-$dir = dir "C:/Program Files (x86)/Windows Kits/10/bin/" | ?{$_.PSISContainer}
+$dir = Get-ChildItem "C:/Program Files (x86)/Windows Kits/10/bin/" | Where-Object{$_.PSISContainer}
 
 $newest_version = 0
 $newest_version_path = ""
 foreach ($d in $dir) {
-    if (-Not ($d.EndsWith('.0'))) {
+    if (-Not ($d.FullName.EndsWith('.0'))) {
         Write-Host "Skip $($d)"
         continue
     }
 
-    if (-Not (Test-Path "$($d)\x64\signtool.exe" -PathType Leaf)) {
+    if (-Not (Test-Path "$($d.FullName)\x64\signtool.exe" -PathType Leaf)) {
         Write-Host "[no exe] Skip $($d)"
         continue
     }
 
-    $leaf = $d.split("\")[-1]
+    $leaf = $d.FullName.split("\")[-1]
     Write-Host "Leaf: $leaf"
 
     $version = $leaf -replace ".","" -as [int]
@@ -30,11 +51,3 @@ $signtool = "$($newest_version_path)\x64\signtool.exe"
 
 Write-Host "Signtool: $($signtool)"
 
-#certificate: '${{ secrets.SIGNTOOL_CERT }}'
-#password: '${{ secrets.SIGNTOOL_PASS }}'
-#certificatesha1: '${{ secrets.SIGNTOOL_FINGERPRINT }}'
-#certificatename: '${{ secrets.SIGNTOOL_NAME }}'
-#description: 'scsd-gui'
-#timestampUrl: 'http://timestamp.digicert.com'
-#folder: 'dist'
-#recursive: true