Prevent Sign Collision

Author: hhhhhojeihsu

.github/workflows/check-test-build.yml

@@ -84,9 +84,9 @@ jobs:
         run: |
           $version_raw = Get-Content ./version.txt -Raw
           $version = $version_raw -replace "`n",""  -replace "`r",""
-          $filename = "scsd-gui_${version}_windows_amd64.exe"
+          $unsigned_filename = "unsigned_${version}_windows_amd64.exe"
           .\scripts\build\windows\set_version_from_template.ps1
-          pyinstaller --version-file "./version_windows.txt" --add-data "version.txt;." --icon "./steamCloudSaveDownloaderGUI/res/scsd_256.ico" --hide-console hide-late --collect-all steamCloudSaveDownloaderGUI --collect-all dateutil --collect-all steamCloudSaveDownloader --onefile ./scsd-gui --name $filename
+          pyinstaller --version-file "./version_windows.txt" --add-data "version.txt;." --icon "./steamCloudSaveDownloaderGUI/res/scsd_256.ico" --hide-console hide-late --collect-all steamCloudSaveDownloaderGUI --collect-all dateutil --collect-all steamCloudSaveDownloader --onefile ./scsd-gui --name $unsigned_filename
 
       - name: Sign (Windows)
         if: ${{ matrix.os == 'windows-latest' }}
@@ -101,6 +101,16 @@ jobs:
           folder: 'dist'
           recursive: true
 
+      # Rename because signing proecdure will collide filename & certname
+      - name: Rename (Windows)
+        if: ${{ matrix.os == 'windows-latest' }}
+        run: |
+          $version_raw = Get-Content ./version.txt -Raw
+          $version = $version_raw -replace "`n",""  -replace "`r",""
+          $unsigned_filename = "unsigned_${version}_windows_amd64.exe"
+          $signed_filename = "scsd-gui_${version}_windows_amd64.exe"
+          Move-Item $unsigned_filename $signed_filename
+
       - name: Build
         if: ${{ matrix.os == 'ubuntu-latest' }}
         run: |