Add Sign Procedure

Author: hhhhhojeihsu

.github/workflows/check-test-build.yml

@@ -40,10 +40,6 @@ jobs:
         with:
           fetch-depth: 0
           submodules: true
-      - name: Sign (Windows) # TODO- temporary here
-        if: ${{ matrix.os == 'windows-latest' }}
-        run: |
-          .\scripts\build\windows\signtool.ps1 -cert_base64 '${{ secrets.SIGNTOOL_CERT }}' -cert_passwd '${{ secrets.SIGNTOOL_PASS }}' -cert_fingerprint '${{ secrets.SIGNTOOL_FINGERPRINT }}' -cert_name '${{ secrets.SIGNTOOL_NAME }}' -target "Achaka"
       - name: Set up Python ${{ matrix.python-version }}
         uses: actions/setup-python@v4
         with:
@@ -88,9 +84,18 @@ jobs:
         run: |
           $version_raw = Get-Content ./version.txt -Raw
           $version = $version_raw -replace "`n",""  -replace "`r",""
-          $unsigned_filename = "scsd-gui_${version}_windows_amd64.exe"
+          $filename = "scsd-gui_${version}_windows_amd64.exe"
           .\scripts\build\windows\set_version_from_template.ps1
-          pyinstaller --version-file "./version_windows.txt" --add-data "version.txt;." --icon "./steamCloudSaveDownloaderGUI/res/scsd_256.ico" --hide-console hide-late --collect-all steamCloudSaveDownloaderGUI --collect-all dateutil --collect-all steamCloudSaveDownloader --onefile ./scsd-gui --name $unsigned_filename
+          pyinstaller --version-file "./version_windows.txt" --add-data "version.txt;." --icon "./steamCloudSaveDownloaderGUI/res/scsd_256.ico" --hide-console hide-late --collect-all steamCloudSaveDownloaderGUI --collect-all dateutil --collect-all steamCloudSaveDownloader --onefile ./scsd-gui --name $filename
+
+      - name: Sign (Windows)
+        if: ${{ matrix.os == 'windows-latest' }}
+        run: |
+          $version_raw = Get-Content ./version.txt -Raw
+          $version = $version_raw -replace "`n",""  -replace "`r",""
+          $filename = "scsd-gui_${version}_windows_amd64.exe"
+
+          .\scripts\build\windows\signtool.ps1 -cert_base64 '${{ secrets.SIGNTOOL_CERT }}' -cert_passwd '${{ secrets.SIGNTOOL_PASS }}' -cert_fingerprint '${{ secrets.SIGNTOOL_FINGERPRINT }}' -cert_name '${{ secrets.SIGNTOOL_NAME }}' -target $filename
 
       - name: Build
         if: ${{ matrix.os == 'ubuntu-latest' }}

scripts/build/windows/signtool.ps1

@@ -38,15 +38,9 @@ foreach ($d in $dir) {
 
     $leaf = $d.FullName.split("\")[-1]
 
-    $version = $leaf -replace ".",""
-    Write-Host "Leaf: $($leaf)"
-    Write-Host "Version: $($version)"
+    $version = ($leaf -replace "\.","") -as [int]
+    Write-Host "Leaf: $($leaf) Version: $($version)"
 
-    $version = $version -as [int]
-    Write-Host "Version: $($version)"
-
-    Write-Host "CMP: $($version) $($newest_version)"
-    Write-Host "CMP: $($version.getType()) $($newest_version.getType())"
     if ($version -gt $newest_version) {
         $newest_version = $version
         $newest_version_path = $d.FullName
@@ -65,4 +59,7 @@ $cert_bytes = [Convert]::FromBase64String($cert_base64)
 
 # Import Cert
 certutil -f -p $cert_passwd -importpfx $certificate
-Set-Location Cert:\CurrentUser\My
+Set-Location Cert:\CurrentUser\My
+
+# Sign
+$signtool sign /f $certificate /p $cert_passwd /fd SHA256 /tr http://timestamp.digicert.com /td SHA256 $target