Fix pylint errors (#1615) (#1616)

Author: manoelmarques

constraints.txt

@@ -1,3 +1,3 @@
-astroid==2.5
-pylint==2.7.1
+astroid==2.5.6
+pylint==2.8.3
 numpy>=1.20.0 ; python_version>'3.6'

qiskit/aqua/components/uncertainty_models/uncertainty_model.py

@@ -1,6 +1,6 @@
 # This code is part of Qiskit.
 #
-# (C) Copyright IBM 2018, 2020.
+# (C) Copyright IBM 2018, 2021.
 #
 # This code is licensed under the Apache License, Version 2.0. You may
 # obtain a copy of this license in the LICENSE.txt file in the root directory
@@ -25,8 +25,6 @@ class UncertaintyModel(CircuitFactory, ABC):
     The abstract Uncertainty Model
     """
 
-    __REPLACEMENT = 'a qiskit.QuantumCircuit'
-
     # pylint: disable=useless-super-delegation
     def __init__(self, num_target_qubits: int) -> None:
         validate_min('num_target_qubits', num_target_qubits, 1)

qiskit/aqua/components/uncertainty_problems/multivariate_problem.py

@@ -1,6 +1,6 @@
 # This code is part of Qiskit.
 #
-# (C) Copyright IBM 2019, 2020.
+# (C) Copyright IBM 2019, 2021.
 #
 # This code is licensed under the Apache License, Version 2.0. You may
 # obtain a copy of this license in the LICENSE.txt file in the root directory
@@ -190,7 +190,7 @@ def build(self, qc, q, q_ancillas=None, params=None):
 
             else:
 
-                for j in range(len(self._conditions)):
+                for j, _ in enumerate(self._conditions):
 
                     dimension = self._conditions[j][0]
                     condition = self._conditions[j][1]
@@ -233,7 +233,7 @@ def build(self, qc, q, q_ancillas=None, params=None):
                 qc.mct(q_cond_target[:-1], q_cond_target[-1], q_rem_ancillas)
 
                 # uncompute condition
-                for j in range(len(self._conditions)):
+                for j, _ in enumerate(self._conditions):
 
                     dimension = self._conditions[j][0]
                     condition = self._conditions[j][1]

qiskit/aqua/operators/legacy/weighted_pauli_operator.py

@@ -267,7 +267,7 @@ def _scaling_weight(self, scaling_factor, copy=False):
                 "Type of scaling factor is a valid type. {} if given.".format(
                     scaling_factor.__class__))
         ret = self.copy() if copy else self
-        for idx in range(len(ret._paulis)):
+        for idx, _ in enumerate(ret._paulis):
             ret._paulis[idx] = [ret._paulis[idx][0] * scaling_factor, ret._paulis[idx][1]]
         return ret
 

qiskit/aqua/utils/run_circuits.py

@@ -106,7 +106,7 @@ def _maybe_split_qobj_by_gates(qobjs: List[QasmQobj], qobj: QasmQobj) -> List[Qa
     if MAX_GATES_PER_JOB is not None:
         max_gates_per_job = int(MAX_GATES_PER_JOB)
         total_num_gates = 0
-        for j in range(len(qobj.experiments)):
+        for j, _ in enumerate(qobj.experiments):
             total_num_gates += len(qobj.experiments[j].instructions)
         # split by gates if total number of gates in a qobj exceed MAX_GATES_PER_JOB
         if total_num_gates > max_gates_per_job:
@@ -116,7 +116,7 @@ def _maybe_split_qobj_by_gates(qobjs: List[QasmQobj], qobj: QasmQobj) -> List[Qa
             temp_qobj.qobj_id = str(uuid.uuid4())
             temp_qobj.experiments = []
             num_gates = 0
-            for i in range(len(qobj.experiments)):
+            for i, _ in enumerate(qobj.experiments):
                 num_gates += len(qobj.experiments[i].instructions)
                 if num_gates <= max_gates_per_job:
                     temp_qobj.experiments.append(qobj.experiments[i])

qiskit/chemistry/bosonic_operator.py

@@ -227,7 +227,7 @@ def direct_mapping_filtering_criterion(self, state: Union[List, np.ndarray], val
                                   dtype='S1').astype(int)
             count = 0
             nqi = 0
-            for m in range(len(self._basis)):
+            for m, _ in enumerate(self._basis):
                 sub_bin = bin_i[nqi:nqi + self._basis[m]]
                 occ_i = 0
                 for idx_i in sub_bin:

qiskit/chemistry/components/variational_forms/uccsd.py

@@ -190,7 +190,7 @@ def __init__(self,
 
             # this will order the hopping operators
             self.labeled_double_excitations = []
-            for i in range(len(self._double_excitations)):
+            for i, _ in enumerate(self._double_excitations):
                 self.labeled_double_excitations.append((self._double_excitations[i], i))
 
             order_hopping_op = UCCSD.order_labels_for_hopping_ops(self._double_excitations,

qiskit/chemistry/drivers/fcidumpd/fcidumpdriver.py

@@ -17,7 +17,7 @@
 from ...qiskit_chemistry_error import QiskitChemistryError
 from ...qmolecule import QMolecule
 from .dumper import dump
-from .parser import parse
+from .parser import parse  # pylint: disable=deprecated-module
 
 
 class FCIDumpDriver(FermionicDriver):

qiskit/chemistry/results/vibronic_structure_result.py

@@ -1,6 +1,6 @@
 # This code is part of Qiskit.
 #
-# (C) Copyright IBM 2020.
+# (C) Copyright IBM 2020, 2021.
 #
 # This code is licensed under the Apache License, Version 2.0. You may
 # obtain a copy of this license in the LICENSE.txt file in the root directory
@@ -73,7 +73,7 @@ def formatted(self) -> List[str]:
                      format(np.round(self.computed_vibronic_energies[0], 12)))
         if len(self.num_occupied_modals_per_mode) > 0:
             lines.append('The number of occupied modals is')
-        for i in range(len(self.num_occupied_modals_per_mode)):
+        for i, _ in enumerate(self.num_occupied_modals_per_mode):
             lines.append('- Mode {}: {}'.format(i, self.num_occupied_modals_per_mode[i]))
 
         return lines

requirements-dev.txt

@@ -1,7 +1,7 @@
 coverage>=4.4.0
 matplotlib>=2.1
 pycodestyle
-pylint>=2.7.1
+pylint>=2.8.3
 pylintfileheader>=0.0.2
 pylatexenc>=1.4
 stestr>=2.0.0