Skip to content
This repository was archived by the owner on Apr 30, 2022. It is now read-only.

Commit 589fe3c

Browse files
42BA-Scott-Rowe
authored andcommitted
Use six.moves instead of try/except ImportError, reorder imports (#129)
* Use `six.moves` instead of `try/except ImportError`, reorder imports * Update test_datatable.py
1 parent 985e1a7 commit 589fe3c

File tree

4 files changed

+27
-42
lines changed

4 files changed

+27
-42
lines changed

quandl/model/database.py

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,16 @@
1-
try:
2-
from urllib.parse import urlparse
3-
from urllib.parse import urlencode
4-
except ImportError:
5-
from urlparse import urlparse
6-
from urllib import urlencode
7-
81
import os
92

3+
from six.moves.urllib.parse import urlencode, urlparse
4+
5+
import quandl.model.dataset
106
from quandl.api_config import ApiConfig
117
from quandl.connection import Connection
12-
from quandl.util import Util
138
from quandl.errors.quandl_error import QuandlError
9+
from quandl.message import Message
1410
from quandl.operations.get import GetOperation
1511
from quandl.operations.list import ListOperation
12+
from quandl.util import Util
1613
from .model_base import ModelBase
17-
from quandl.message import Message
18-
import quandl.model.dataset
1914

2015

2116
class Database(GetOperation, ListOperation, ModelBase):

quandl/model/datatable.py

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,17 @@
1-
try:
2-
from urllib.request import urlopen
3-
except ImportError:
4-
from urllib import urlopen
5-
6-
from time import sleep
71
import os
2+
from time import sleep
3+
4+
from six.moves.urllib.request import urlopen
85

96
from quandl.connection import Connection
10-
from quandl.util import Util
117
from quandl.errors.quandl_error import QuandlError
8+
from quandl.message import Message
129
from quandl.operations.get import GetOperation
1310
from quandl.operations.list import ListOperation
11+
from quandl.util import Util
1412
from quandl.utils.request_type_util import RequestType
15-
16-
from .model_base import ModelBase
17-
from quandl.message import Message
1813
from .data import Data
14+
from .model_base import ModelBase
1915

2016

2117
class Datatable(GetOperation, ListOperation, ModelBase):

test/test_database.py

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,19 @@
1-
try:
2-
from urllib.parse import urlparse
3-
from urllib.parse import parse_qs
4-
except ImportError:
5-
from urlparse import urlparse
6-
from cgi import parse_qs
7-
1+
import json
82
import re
93
import unittest
10-
from test.helpers.httpretty_extension import httpretty
11-
import json
4+
125
import six
13-
from quandl.errors.quandl_error import (InternalServerError, QuandlError)
6+
from mock import call, mock_open, patch
7+
from six.moves.urllib.parse import parse_qs, urlparse
8+
149
from quandl.api_config import ApiConfig
15-
from quandl.model.database import Database
1610
from quandl.connection import Connection
17-
from test.test_retries import ModifyRetrySettingsTestCase
18-
from mock import patch, call, mock_open
11+
from quandl.errors.quandl_error import (InternalServerError, QuandlError)
12+
from quandl.model.database import Database
1913
from test.factories.database import DatabaseFactory
2014
from test.factories.meta import MetaFactory
15+
from test.helpers.httpretty_extension import httpretty
16+
from test.test_retries import ModifyRetrySettingsTestCase
2117

2218

2319
class GetDatabaseTest(unittest.TestCase):

test/test_datatable.py

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,18 @@
1-
try:
2-
from urllib.parse import urlparse
3-
except ImportError:
4-
from urlparse import urlparse
5-
1+
import json
62
import re
73
import unittest
4+
85
import httpretty
9-
import json
106
import six
7+
from mock import call, mock_open, patch
8+
from six.moves.urllib.parse import urlparse
9+
10+
from quandl.api_config import ApiConfig
11+
from quandl.errors.quandl_error import (InternalServerError, QuandlError)
1112
from quandl.model.datatable import Datatable
12-
from mock import patch, call, mock_open
1313
from test.factories.datatable import DatatableFactory
1414
from test.test_retries import ModifyRetrySettingsTestCase
15-
from quandl.api_config import ApiConfig
1615
from quandl.utils.request_type_util import RequestType
17-
from quandl.errors.quandl_error import (InternalServerError, QuandlError)
1816
from parameterized import parameterized
1917

2018

0 commit comments

Comments
 (0)