core/itemimagegrab: remove target prop

Also format

Author: soramanew

src/core/itemimagegrab.cpp

@@ -7,37 +7,35 @@
 #include <qthreadpool.h>
 #include <qtmetamacros.h>
 
-QQuickItem* ItemImageGrab::target() const { return this->mTarget; }
-
-void ItemImageGrab::setTarget(QQuickItem* target) {
-    if (target == this->mTarget) return;
-
-    this->mTarget = target;
-    emit this->targetChanged();
+void ItemImageGrab::grab(QQuickItem* target, const QUrl& path) {
+	this->grab(target, path, QSize());
 }
 
-void ItemImageGrab::grab(const QUrl& path) { this->grab(this->mTarget, path); }
-
-void ItemImageGrab::grab(const QUrl& path, const QSize& targetSize) { this->grab(this->mTarget, path, targetSize); }
-
-void ItemImageGrab::grab(QQuickItem* target, const QUrl& path) { this->grab(target, path, QSize()); }
-
 void ItemImageGrab::grab(QQuickItem* target, const QUrl& path, const QSize& targetSize) {
-    if (!target) return;
-
-    QSharedPointer<QQuickItemGrabResult> grabResult;
-    if (targetSize.isEmpty()){
-        grabResult = target->grabToImage();
-    }else{
-        grabResult = target->grabToImage(targetSize);}
-
-    QObject::connect(grabResult.data(), &QQuickItemGrabResult::ready, this, [grabResult, path, this]() {
-        QThreadPool::globalInstance()->start([grabResult, path, this] {
-            if (grabResult->saveToFile(path)) {
-                emit this->saved(path);
-            } else {
-                emit this->failed(path);
-            }
-        });
-    });
+	if (!target) {
+		qWarning() << "ItemImageGrab::grab: a target is required";
+		return;
+	}
+
+	QSharedPointer<QQuickItemGrabResult> grabResult;
+	if (targetSize.isEmpty()) {
+		grabResult = target->grabToImage();
+	} else {
+		grabResult = target->grabToImage(targetSize);
+	}
+
+	QObject::connect(
+	    grabResult.data(),
+	    &QQuickItemGrabResult::ready,
+	    this,
+	    [grabResult, path, this]() {
+		    QThreadPool::globalInstance()->start([grabResult, path, this] {
+			    if (grabResult->saveToFile(path)) {
+				    emit this->saved(path);
+			    } else {
+				    emit this->failed(path);
+			    }
+		    });
+	    }
+	);
 }

src/core/itemimagegrab.hpp

@@ -7,27 +7,15 @@
 /// Allows for saving an item grab to an file asynchronously.
 class ItemImageGrab: public QObject {
 	Q_OBJECT;
-
-    Q_PROPERTY(QQuickItem *target READ target WRITE setTarget NOTIFY targetChanged);
-    QML_ELEMENT;
+	QML_ELEMENT;
 
 public:
 	explicit ItemImageGrab(QObject* parent = nullptr): QObject(parent) {};
 
-	[[nodiscard]] QQuickItem* target() const;
-	void setTarget(QQuickItem* target);
-
-    Q_INVOKABLE void grab(const QUrl& path);
-    Q_INVOKABLE void grab(const QUrl& path, const QSize& targetSize);
-    Q_INVOKABLE void grab(QQuickItem* target, const QUrl& path);
-    Q_INVOKABLE void grab(QQuickItem* target, const QUrl& path, const QSize& targetSize);
+	Q_INVOKABLE void grab(QQuickItem* target, const QUrl& path);
+	Q_INVOKABLE void grab(QQuickItem* target, const QUrl& path, const QSize& targetSize);
 
 signals:
-    void saved(const QUrl& path);
-    void failed(const QUrl& path);
-
-	void targetChanged();
-
-private:
-	QPointer<QQuickItem> mTarget;
+	void saved(const QUrl& path);
+	void failed(const QUrl& path);
 };