Skip to content

Commit 70be74e

Browse files
committed
io/fileview: add write support
FileView is now getting somewhat out of hand. The asynchronous parts especially need to be redone, but this will work for now.
1 parent 2d05c7a commit 70be74e

File tree

3 files changed

+541
-124
lines changed

3 files changed

+541
-124
lines changed

src/io/FileView.qml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,21 @@ FileViewInternal {
44
property bool preload: this.__preload;
55
property bool blockLoading: this.__blockLoading;
66
property bool blockAllReads: this.__blockAllReads;
7+
property bool printErrors: this.__printErrors;
78
property string path: this.__path;
89

910
onPreloadChanged: this.__preload = preload;
1011
onBlockLoadingChanged: this.__blockLoading = this.blockLoading;
1112
onBlockAllReadsChanged: this.__blockAllReads = this.blockAllReads;
13+
onPrintErrorsChanged: this.__printErrors = this.printErrors;
1214

1315
// Unfortunately path can't be kept as an empty string until the file loads
1416
// without using QQmlPropertyValueInterceptor which is private. If we lean fully
1517
// into using private code in the future, there will be no reason not to do it here.
1618

1719
onPathChanged: {
1820
if (!this.preload) this.__preload = false;
21+
this.__printErrors = this.printErrors;
1922
this.__path = this.path;
2023
if (this.preload) this.__preload = true;
2124
}
@@ -30,16 +33,18 @@ FileViewInternal {
3033
if (!this.preload) this.__preload = false;
3134
this.__blockLoading = this.blockLoading;
3235
this.__blockAllReads = this.blockAllReads;
36+
this.__printErrors = this.printErrors;
3337
this.__path = this.path;
3438
const text = this.__text;
3539
if (this.preload) this.__preload = true;
3640
return text;
3741
}
3842

39-
function data(): string {
43+
function data(): var {
4044
if (!this.preload) this.__preload = false;
4145
this.__blockLoading = this.blockLoading;
4246
this.__blockAllReads = this.blockAllReads;
47+
this.__printErrors = this.printErrors;
4348
this.__path = this.path;
4449
const data = this.__data;
4550
if (this.preload) this.__preload = true;

0 commit comments

Comments
 (0)