permissive key validation #243

eblondel · eblondel · commit 20b5b0b5315e · 2025-05-22T16:46:43.000+02:00
diff --git a/R/geoflow_validator.R b/R/geoflow_validator.R
@@ -160,7 +160,7 @@ geoflow_validator_cell <- R6Class("geoflow_validator_cell",
                 if(private$key_required) report <- rbind(report, data.frame(type = "ERROR", message = sprintf("Key is omitted, with no default key, please check the documentation")))
               }
             }else{
-              if(!kvp$key %in% private$valid_keys){
+              if(!tolower(kvp$key) %in% tolower(private$valid_keys)){
                 #warning --> indicate key will be ignored
                 if(private$error_if_invalid_key){
                   report <- rbind(report, data.frame(type = "ERROR", message = sprintf("Key '%s' is invalid, allowed key values are [%s]", kvp$key, paste0(private$valid_keys, collapse = ","))))

Original file line number	Diff line number	Diff line change
`@@ -160,7 +160,7 @@ geoflow_validator_cell <- R6Class("geoflow_validator_cell",`
`160`	`160`	`if(private$key_required) report <- rbind(report, data.frame(type = "ERROR", message = sprintf("Key is omitted, with no default key, please check the documentation")))`
`161`	`161`	`}`
`162`	`162`	`}else{`
`163`		`- if(!kvp$key %in% private$valid_keys){`
	`163`	`+ if(!tolower(kvp$key) %in% tolower(private$valid_keys)){`
`164`	`164`	`#warning --> indicate key will be ignored`
`165`	`165`	`if(private$error_if_invalid_key){`
`166`	`166`	`report <- rbind(report, data.frame(type = "ERROR", message = sprintf("Key '%s' is invalid, allowed key values are [%s]", kvp$key, paste0(private$valid_keys, collapse = ","))))`