don't allow snap level >30

Author: paleolimbot

R/s2-options.R

@@ -109,6 +109,10 @@ s2_snap_identity <- function() {
 #' @rdname s2_options
 #' @export
 s2_snap_level <- function(level) {
+  if (level > 30) {
+    stop("`level` must be an intger between 1 and 30", call. = FALSE)
+  }
+
   structure(list(level = level), class = "snap_level")
 }
 

tests/testthat/test-s2-options.R

@@ -7,4 +7,5 @@ test_that("s2_options() errors are readable", {
   expect_error(s2_intersects("POINT EMPTY", "POINT EMPTY", options = NULL), "must be created using")
   expect_error(s2_options(model = "not a model"), "must be one of")
   expect_error(s2_options(snap_radius = 100), "radius is too large")
+  expect_error(s2_snap_level(31), "between 1 and 30")
 })

tests/testthat/test-s2-transformers.R

@@ -470,12 +470,6 @@ test_that("s2_rebuild() works", {
       )
     )
   )
-
-  # S2Builder error
-  expect_error(
-    s2_rebuild("POINT (0.01 0.01)", options = s2_options(snap = s2_snap_level(32))),
-    "Snap function moved vertex"
-  )
 })
 
 test_that("real data survives the S2BooleanOperation", {