Skip to content

Commit efeec67

Browse files
committed
document changes to S2 source to make the solaris build pass
1 parent dc49125 commit efeec67

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

data-raw/update-s2.R

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,11 @@ print_next <- function() {
8787
cli::cat_bullet("Remove extra semi-colons because of FROMHOST_TYPE_MAP macro (utils/endian/endian.h#565)")
8888
cli::cat_bullet(
8989
"Check for definition of IS_LITTLE_ENDIAN and IS_BIG_ENDIAN to allow configure script ",
90-
"override (s2/base/port.h:273) without macro redefinition warnings"
90+
"override (s2/base/port.h:273) without macro redefinition warnings (for CRAN Solaris)"
91+
)
92+
cli::cat_bullet(
93+
"Replace calls to log(<int literal>), sqrt(<int literal>), and ldexp(<int literal>, ...) ",
94+
"with an explicit doouble (e.g., sqrt(3) -> sqrt(3.0) to fix build errors on CRAN Solaris"
9195
)
9296
cli::cat_bullet("Replace `abort()` with `cpp_compat_abort()`")
9397
cli::cat_bullet("Replace `cerr`/`cout` with `cpp_compat_cerr`/`cpp_compat_cout`")

0 commit comments

Comments
 (0)