Skip to content

Commit 445f3c9

Browse files
committed
make: Move rabbitmq-early-test.mk to rabbitmq-early-plugin.mk
No real need to have two files, especially since it contains only a few variable definitions. Plan is to only keep separate files for larger features such as dist or run.
1 parent 7421d4d commit 445f3c9

File tree

8 files changed

+63
-66
lines changed

8 files changed

+63
-66
lines changed

deps/amqp10_client/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ DEPS = amqp10_common credentials_obfuscation
3333
TEST_DEPS = rabbit rabbitmq_ct_helpers
3434
LOCAL_DEPS = ssl inets crypto public_key
3535

36-
DEP_EARLY_PLUGINS = rabbit_common/mk/rabbitmq-early-test.mk
36+
DEP_EARLY_PLUGINS = rabbit_common/mk/rabbitmq-early-plugin.mk
3737
DEP_PLUGINS = rabbit_common/mk/rabbitmq-build.mk \
3838
rabbit_common/mk/rabbitmq-hexpm.mk \
3939
rabbit_common/mk/rabbitmq-dist.mk \

deps/amqp10_common/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ TEST_DEPS = rabbitmq_ct_helpers proper
3838

3939
-include development.pre.mk
4040

41-
DEP_EARLY_PLUGINS = rabbit_common/mk/rabbitmq-early-test.mk
41+
DEP_EARLY_PLUGINS = rabbit_common/mk/rabbitmq-early-plugin.mk
4242
DEP_PLUGINS = rabbit_common/mk/rabbitmq-build.mk \
4343
rabbit_common/mk/rabbitmq-hexpm.mk \
4444
rabbit_common/mk/rabbitmq-dist.mk

deps/amqp_client/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ LOCAL_DEPS = xmerl ssl public_key
4343
DEPS = rabbit_common credentials_obfuscation
4444
TEST_DEPS = rabbitmq_ct_helpers rabbit meck
4545

46-
DEP_EARLY_PLUGINS = rabbit_common/mk/rabbitmq-early-test.mk
46+
DEP_EARLY_PLUGINS = rabbit_common/mk/rabbitmq-early-plugin.mk
4747
DEP_PLUGINS = rabbit_common/mk/rabbitmq-build.mk \
4848
rabbit_common/mk/rabbitmq-hexpm.mk \
4949
rabbit_common/mk/rabbitmq-dist.mk \

deps/oauth2_client/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ LOCAL_DEPS = ssl inets crypto public_key
99

1010
PLT_APPS = rabbit
1111

12-
DEP_EARLY_PLUGINS = rabbit_common/mk/rabbitmq-early-test.mk
12+
DEP_EARLY_PLUGINS = rabbit_common/mk/rabbitmq-early-plugin.mk
1313
DEP_PLUGINS = rabbit_common/mk/rabbitmq-build.mk \
1414
rabbit_common/mk/rabbitmq-hexpm.mk \
1515
rabbit_common/mk/rabbitmq-dist.mk \

deps/rabbit/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ MANPAGES = $(wildcard $(DOCS_DIR)/*.[0-9])
154154
WEB_MANPAGES = $(patsubst %,%.html,$(MANPAGES))
155155
MD_MANPAGES = $(patsubst %,%.md,$(MANPAGES))
156156

157-
DEP_EARLY_PLUGINS = rabbit_common/mk/rabbitmq-early-test.mk
157+
DEP_EARLY_PLUGINS = rabbit_common/mk/rabbitmq-early-plugin.mk
158158
DEP_PLUGINS = rabbit_common/mk/rabbitmq-build.mk \
159159
rabbit_common/mk/rabbitmq-dist.mk \
160160
rabbit_common/mk/rabbitmq-run.mk

deps/rabbit_common/Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ DEPS = thoas ranch recon credentials_obfuscation
3838

3939
-include development.pre.mk
4040

41-
DEP_EARLY_PLUGINS = $(PROJECT)/mk/rabbitmq-early-test.mk
41+
DEP_EARLY_PLUGINS = $(PROJECT)/mk/rabbitmq-early-plugin.mk
4242
DEP_PLUGINS = $(PROJECT)/mk/rabbitmq-build.mk \
4343
$(PROJECT)/mk/rabbitmq-hexpm.mk \
4444
$(PROJECT)/mk/rabbitmq-dist.mk
@@ -52,7 +52,7 @@ HEX_TARBALL_FILES += rabbitmq-components.mk \
5252
git-revisions.txt \
5353
mk/rabbitmq-build.mk \
5454
mk/rabbitmq-dist.mk \
55-
mk/rabbitmq-early-test.mk \
55+
mk/rabbitmq-early-plugin.mk \
5656
mk/rabbitmq-hexpm.mk
5757

5858
-include development.post.mk
Lines changed: 56 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,57 @@
1-
ifeq ($(filter rabbitmq-early-test.mk,$(notdir $(MAKEFILE_LIST))),)
2-
include $(dir $(lastword $(MAKEFILE_LIST)))rabbitmq-early-test.mk
1+
# --------------------------------------------------------------------
2+
# dialyzer
3+
# --------------------------------------------------------------------
4+
5+
DIALYZER_OPTS ?= -Werror_handling -Wunmatched_returns -Wunknown
6+
7+
dialyze: ERL_LIBS = $(APPS_DIR):$(DEPS_DIR):$(DEPS_DIR)/rabbitmq_cli/_build/dev/lib:$(dir $(shell elixir --eval ":io.format '~s~n', [:code.lib_dir :elixir ]"))
8+
9+
# --------------------------------------------------------------------
10+
# Common Test flags.
11+
# --------------------------------------------------------------------
12+
13+
# We start the common_test node as a hidden Erlang node. The benefit
14+
# is that other Erlang nodes won't try to connect to each other after
15+
# discovering the common_test node if they are not meant to.
16+
#
17+
# This helps when several unrelated RabbitMQ clusters are started in
18+
# parallel.
19+
20+
CT_OPTS += -hidden
21+
22+
# Enable the following common_test hooks on GH and Concourse:
23+
#
24+
# cth_fail_fast
25+
# This hook will make sure the first failure puts an end to the
26+
# testsuites; ie. all remaining tests are skipped.
27+
#
28+
# cth_styledout
29+
# This hook will change the output of common_test to something more
30+
# concise and colored.
31+
32+
CT_HOOKS ?= cth_styledout
33+
TEST_DEPS += cth_styledout
34+
35+
ifdef CONCOURSE
36+
FAIL_FAST = 1
37+
SKIP_AS_ERROR = 1
38+
endif
39+
40+
RMQ_CI_CT_HOOKS = cth_fail_fast
41+
ifeq ($(FAIL_FAST),1)
42+
CT_HOOKS += $(RMQ_CI_CT_HOOKS)
43+
TEST_DEPS += $(RMQ_CI_CT_HOOKS)
44+
endif
45+
46+
dep_cth_fail_fast = git https://github.com/rabbitmq/cth_fail_fast.git master
47+
dep_cth_styledout = git https://github.com/rabbitmq/cth_styledout.git master
48+
49+
CT_HOOKS_PARAM_VALUE = $(patsubst %,and %,$(CT_HOOKS))
50+
CT_OPTS += -ct_hooks $(wordlist 2,$(words $(CT_HOOKS_PARAM_VALUE)),$(CT_HOOKS_PARAM_VALUE))
51+
52+
# On CI, set $RABBITMQ_CT_SKIP_AS_ERROR so that any skipped
53+
# testsuite/testgroup/testcase is considered an error.
54+
55+
ifeq ($(SKIP_AS_ERROR),1)
56+
export RABBITMQ_CT_SKIP_AS_ERROR = true
357
endif

deps/rabbit_common/mk/rabbitmq-early-test.mk

Lines changed: 0 additions & 57 deletions
This file was deleted.

0 commit comments

Comments
 (0)