Improve EKS node group desired_size error message (#1205)

kkaempf · web-flow · commit e2e1f9e8ee63 · 2023-09-19T16:09:27.000-04:00
diff --git a/rancher2/resource_rancher2_cluster.go b/rancher2/resource_rancher2_cluster.go
@@ -149,7 +149,7 @@ func resourceRancher2ClusterCreate(d *schema.ResourceData, meta interface{}) err
 	newCluster := &Cluster{}
 	if cluster.EKSConfig != nil && !cluster.EKSConfig.Imported {
 		if !checkClusterEKSConfigV2NodeGroupsDesiredSize(cluster) {
-			return fmt.Errorf("[ERROR] can't create %s EKS cluster with node group desired_size = 0", cluster.Name)
+			return fmt.Errorf("[ERROR] can't create %s EKS cluster with node group desired_size = 0. desired_size must be >=1. After initial provisioning, desired_size may be scaled down to 0 at any time", cluster.Name)
 		}
 		clusterStr, _ := interfaceToJSON(cluster)
 		clusterMap, _ := jsonToMapInterface(clusterStr)

Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,7 @@ func resourceRancher2ClusterCreate(d *schema.ResourceData, meta interface{}) err`
`149`	`149`	`newCluster := &Cluster{}`
`150`	`150`	`if cluster.EKSConfig != nil && !cluster.EKSConfig.Imported {`
`151`	`151`	`if !checkClusterEKSConfigV2NodeGroupsDesiredSize(cluster) {`
`152`		`- return fmt.Errorf("[ERROR] can't create %s EKS cluster with node group desired_size = 0", cluster.Name)`
	`152`	`+ return fmt.Errorf("[ERROR] can't create %s EKS cluster with node group desired_size = 0. desired_size must be >=1. After initial provisioning, desired_size may be scaled down to 0 at any time", cluster.Name)`
`153`	`153`	`}`
`154`	`154`	`clusterStr, _ := interfaceToJSON(cluster)`
`155`	`155`	`clusterMap, _ := jsonToMapInterface(clusterStr)`