fixup! fixup! fixup! jira

wip

Author: bgaidioz

examples/jira/python/jira_endpoints.py

@@ -8,13 +8,20 @@
 from typing import Dict, Any, List, Optional
 import logging
 from atlassian import Jira
-from mxcp.runtime import config, db
+from mxcp.runtime import config, db, on_init, on_shutdown
 
 logger = logging.getLogger(__name__)
 
+# Global JIRA client for reuse across all function calls
+jira_client: Optional[Jira] = None
 
-def _get_jira_client() -> Jira:
-    """Get configured JIRA client from secrets."""
+
+@on_init
+def setup_jira_client():
+    """Initialize JIRA client when server starts."""
+    global jira_client
+    logger.info("Initializing JIRA client...")
+    
     jira_config = config.get_secret("jira")
     if not jira_config:
         raise ValueError("JIRA configuration not found. Please configure JIRA secrets in your user config.")
@@ -24,12 +31,31 @@ def _get_jira_client() -> Jira:
     if missing_keys:
         raise ValueError(f"Missing JIRA configuration keys: {', '.join(missing_keys)}")
 
-    return Jira(
+    jira_client = Jira(
         url=jira_config["url"],
         username=jira_config["username"],
         password=jira_config["password"],
         cloud=True
     )
+    
+    logger.info("JIRA client initialized successfully")
+
+
+@on_shutdown
+def cleanup_jira_client():
+    """Clean up JIRA client when server stops."""
+    global jira_client
+    if jira_client:
+        # JIRA client doesn't need explicit cleanup, but we'll clear the reference
+        jira_client = None
+        logger.info("JIRA client cleaned up")
+
+
+def _get_jira_client() -> Jira:
+    """Get the global JIRA client."""
+    if jira_client is None:
+        raise RuntimeError("JIRA client not initialized. Make sure the server is started properly.")
+    return jira_client
 
 
 def jql_query(query: str, start: Optional[int] = 0, limit: Optional[int] = None) -> List[Dict[str, Any]]:

examples/salesforce/python/salesforce_endpoints.py

@@ -9,13 +9,20 @@
 import logging
 import json
 import simple_salesforce
-from mxcp.runtime import config
+from mxcp.runtime import config, on_init, on_shutdown
 
 logger = logging.getLogger(__name__)
 
+# Global Salesforce client for reuse across all function calls
+sf_client: Optional[simple_salesforce.Salesforce] = None
 
-def _get_salesforce_client() -> simple_salesforce.Salesforce:
-    """Get configured Salesforce client from secrets."""
+
+@on_init
+def setup_salesforce_client():
+    """Initialize Salesforce client when server starts."""
+    global sf_client
+    logger.info("Initializing Salesforce client...")
+    
     sf_config = config.get_secret("salesforce")
     if not sf_config:
         raise ValueError("Salesforce configuration not found. Please configure Salesforce secrets in your user config.")
@@ -25,13 +32,32 @@ def _get_salesforce_client() -> simple_salesforce.Salesforce:
     if missing_keys:
         raise ValueError(f"Missing Salesforce configuration keys: {', '.join(missing_keys)}")
 
-    return simple_salesforce.Salesforce(
+    sf_client = simple_salesforce.Salesforce(
         username=sf_config["username"],
         password=sf_config["password"],
         security_token=sf_config["security_token"],
         instance_url=sf_config["instance_url"],
         client_id=sf_config["client_id"]
     )
+    
+    logger.info("Salesforce client initialized successfully")
+
+
+@on_shutdown
+def cleanup_salesforce_client():
+    """Clean up Salesforce client when server stops."""
+    global sf_client
+    if sf_client:
+        # Salesforce client doesn't need explicit cleanup, but we'll clear the reference
+        sf_client = None
+        logger.info("Salesforce client cleaned up")
+
+
+def _get_salesforce_client() -> simple_salesforce.Salesforce:
+    """Get the global Salesforce client."""
+    if sf_client is None:
+        raise RuntimeError("Salesforce client not initialized. Make sure the server is started properly.")
+    return sf_client
 
 
 def soql(query: str) -> List[Dict[str, Any]]: