jCard property names and parameter names must be lowercase (thx Jan Willem Stegink)

Author: gbxyz

lib/rdap-validator.js

@@ -66,7 +66,8 @@ self.testURL = function(url, type, serverType, context) {
 };
 
 /**
- * Invoked when the fetch has completed.
+ * Invoked when the fetch has completed. This tests an HTTP response (ie headers
+ * and body)
  * @param {Response} response
  */
 self.testResponse = function(response) {
@@ -118,6 +119,10 @@ self.testResponse = function(response) {
     );
 };
 
+/**
+ * This is called by testResponse() and validates the JSON body of the response.
+ * @param json
+ */
 self.validateResponse = function(json) {
 
     self.path = ["$"];
@@ -689,6 +694,12 @@ self.validateJCardPropertyType = function(property) {
         "section-3.3",
     )) return;
 
+    self.add(
+        property[0] === property[0].toLowerCase(),
+        `Property name '${property[0]}' MUST be in lowercase.`,
+        "section-3.3",
+    );
+
     if ("rir" == self.lastTestedServerType) {
         self.pushSpec("nro");
 
@@ -713,11 +724,17 @@ self.validateJCardPropertyType = function(property) {
  * Validate a JCard property parameter object.
  */
 self.validateJCardPropertyParameters = function(property) {
-    self.add(
+    if (self.add(
         self.isObject(property[1]),
         "Item #2 of a jCard property MUST be an object.",
         "section-3.3",
-    );
+    )) {
+        self.add(
+            Object.keys(property[1]).length == Object.keys(property[1]).filter(n => n === n.toLowerCase()).length,
+            "jCard parameter names MUST be lowercase.",
+            "section-3.4"
+        )
+    }
 };
 
 /**
@@ -2492,7 +2509,9 @@ self.isULabel = function(label) {
 
 /**
  * This stores the JSONPath query that identifies the value in the response that
- * is currently being validated.
+ * is currently being validated. When add() is called, the a JSON Path
+ * expression is generated using this stack, so the specific component of the
+ * JSON response can be associated with the message.
  */
 self.path = [];
 
@@ -2518,7 +2537,9 @@ self.popPath = function(last) {
 
 /**
  * This keeps track of the specification document that the response is being
- * validated against.
+ * validated against. when add() is called, the topmost entry in the stack is
+ * copied into the message, so the message can be associated with a particular
+ * specification (RFC, etc).
  */
 self.specStack = [];