Skip to content

Commit 844b3cd

Browse files
committed
refactor: use ol instead
1 parent aab80fe commit 844b3cd

File tree

3 files changed

+125
-125
lines changed

3 files changed

+125
-125
lines changed

src/Step.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,8 @@ export default function Step(props: StepProps) {
9898
const accessibilityProps: {
9999
role?: string;
100100
tabIndex?: number;
101-
onClick?: React.MouseEventHandler<HTMLDivElement>;
102-
onKeyDown?: React.KeyboardEventHandler<HTMLDivElement>;
101+
onClick?: React.MouseEventHandler<HTMLLIElement>;
102+
onKeyDown?: React.KeyboardEventHandler<HTMLLIElement>;
103103
} = {};
104104

105105
if (clickable) {
@@ -233,7 +233,7 @@ export default function Step(props: StepProps) {
233233
);
234234

235235
let stepNode: React.ReactNode = (
236-
<div
236+
<li
237237
{...restItemProps}
238238
{...accessibilityProps}
239239
className={classString}
@@ -244,7 +244,7 @@ export default function Step(props: StepProps) {
244244
}}
245245
>
246246
{itemWrapperRender ? itemWrapperRender(wrapperNode) : wrapperNode}
247-
</div>
247+
</li>
248248
);
249249

250250
if (itemRender) {

src/Steps.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ export type StepItem = {
4343
title?: React.ReactNode;
4444
classNames?: Partial<Record<ItemSemanticName, string>>;
4545
styles?: Partial<Record<ItemSemanticName, React.CSSProperties>>;
46-
} & Pick<React.HtmlHTMLAttributes<HTMLDivElement>, 'onClick' | 'className' | 'style'>;
46+
} & Pick<React.HtmlHTMLAttributes<HTMLLIElement>, 'onClick' | 'className' | 'style'>;
4747

4848
export type StepIconRender = (info: {
4949
index: number;
@@ -212,7 +212,7 @@ export default function Steps(props: StepsProps) {
212212
};
213213

214214
return (
215-
<div
215+
<ol
216216
className={classString}
217217
style={{
218218
...style,
@@ -223,6 +223,6 @@ export default function Steps(props: StepsProps) {
223223
<StepsContext.Provider value={stepIconContext}>
224224
{mergedItems.map<React.ReactNode>(renderStep)}
225225
</StepsContext.Provider>
226-
</div>
226+
</ol>
227227
);
228228
}

0 commit comments

Comments
 (0)