Build: last command shows "running" even if build fails

[agjohnson]

I don't recall exactly what we were doing here previously, but it seems like if a build is cancelled or killed early the last command is stuck displaying Running instead of the time used by the command execution.

At very least, the command should show the amount of time spent executing (up until when the build was killed). I believe this was the old behavior.

But it also seems like we may have lost some error reporting on memory/time limit too. The build I notice this on seems like it should have hit a time limit and reported that as the failure. Instead the build had a generic "Unknown problem" error, which prompted the user to contact us. I haven't confirmed that we lost this error though.

[humitos]

I think this happens because the build is killed and there is no API call to update the last command.

A quick and simple solution here would be to check for !build.finished to display the Running label. We cannot know how much time that last command took because it was killed and there is no API call update as I mentioned before.

[humitos]

A quick and simple solution here would be to check for !build.finished to display the Running label.

Weird, we are already doing that https://github.com/readthedocs/ext-theme/blob/main/readthedocsext/theme/templates/builds/build_detail.html#L246-L247

[agjohnson]

That is command finished(), not build finished(). The scope is inside an iteration over foreach: commands:

ext-theme/readthedocsext/theme/templates/builds/build_detail.html

Line 233 in 3834a74

data-bind="css: { hidden: !commands(), 'single line': !is_wrapped() }, foreach: commands">

But yes, the fix is to inspect if the build and command are not yet finished when displaying running. If the build fails we should either show some calculation or guess at the build time or maybe show something like "Incomplete". We might already have an error warning label style too.