const

Author: Recca Tsai

src/Uploaders/Base.php

@@ -10,6 +10,13 @@
 
 abstract class Base implements Uploader
 {
+    /**
+     * TMPFILE_EXTENSION.
+     *
+     * @var string
+     */
+    const TMPFILE_EXTENSION = '.part';
+
     /**
      * $request.
      *
@@ -89,13 +96,14 @@ protected function tmpfile($originalName)
     protected function receiveChunkedFile($originalName, $input, $start, $mimeType, $isCompleted = false, $headers = [])
     {
         $tmpfile = $this->tmpfile($originalName);
-        $this->filesystem->appendStream($tmpfile.'.part', $input, $start);
+        $extension = static::TMPFILE_EXTENSION;
+        $this->filesystem->appendStream($tmpfile.$extension, $input, $start);
 
         if ($isCompleted === false) {
             throw new ChunkedResponseException($headers);
         }
 
-        $this->filesystem->move($tmpfile.'.part', $tmpfile);
+        $this->filesystem->move($tmpfile.$extension, $tmpfile);
         $size = $this->filesystem->size($tmpfile);
 
         return $this->filesystem->createUploadedFile($tmpfile, $originalName, $mimeType, $size);

tests/Uploader/FileAPITest.php

@@ -67,6 +67,7 @@ public function test_upload_chunk_file_throw_chunk_response()
         $extension = pathinfo($originalName, PATHINFO_EXTENSION);
         $mimeType = finfo_file(finfo_open(FILEINFO_MIME_TYPE), $file);
         $tmpfile = $path.'/'.md5($originalName.$token).'.'.$extension;
+        $tmpfileExtension = FileAPI::TMPFILE_EXTENSION;
 
         $start = 5242880;
         $end = 5767167;
@@ -113,7 +114,7 @@ public function test_upload_chunk_file_throw_chunk_response()
         $request->shouldHaveReceived('header')->with('content-type')->once();
         $filesystem->shouldHaveReceived('extension')->with($originalName)->once();
         $request->shouldHaveReceived('get')->with('token')->once();
-        $filesystem->shouldHaveReceived('appendStream')->with($tmpfile.'.part', $input, $start)->once();
+        $filesystem->shouldHaveReceived('appendStream')->with($tmpfile.$tmpfileExtension, $input, $start)->once();
     }
 
     public function test_upload_chunk_file()
@@ -136,6 +137,7 @@ public function test_upload_chunk_file()
         $extension = pathinfo($originalName, PATHINFO_EXTENSION);
         $mimeType = finfo_file(finfo_open(FILEINFO_MIME_TYPE), $file);
         $tmpfile = $path.'/'.md5($originalName.$token).'.'.$extension;
+        $tmpfileExtension = FileAPI::TMPFILE_EXTENSION;
 
         $start = 5242880;
         $end = 7845180;
@@ -160,7 +162,7 @@ public function test_upload_chunk_file()
         $filesystem
             ->shouldReceive('extension')->with($originalName)->andReturn($extension)
             ->shouldReceive('mimeType')->with($originalName)->andReturn($mimeType)
-            ->shouldReceive('move')->with($tmpfile.'.part', $tmpfile)
+            ->shouldReceive('move')->with($tmpfile.$tmpfileExtension, $tmpfile)
             ->shouldReceive('size')->with($tmpfile)->andReturn($total);
 
         $uploader = new FileAPI($request, $filesystem, $path);
@@ -179,8 +181,8 @@ public function test_upload_chunk_file()
         $filesystem->shouldHaveReceived('extension')->with($originalName)->once();
         $filesystem->shouldHaveReceived('mimeType')->with($originalName)->once();
         $request->shouldHaveReceived('get')->with('token')->once();
-        $filesystem->shouldHaveReceived('appendStream')->with($tmpfile.'.part', $input, $start)->once();
-        $filesystem->shouldHaveReceived('move')->with($tmpfile.'.part', $tmpfile)->once();
+        $filesystem->shouldHaveReceived('appendStream')->with($tmpfile.$tmpfileExtension, $input, $start)->once();
+        $filesystem->shouldHaveReceived('move')->with($tmpfile.$tmpfileExtension, $tmpfile)->once();
         $filesystem->shouldHaveReceived('size')->once();
         $filesystem->shouldHaveReceived('createUploadedFile')->with($tmpfile, $originalName, $mimeType, $size)->once();
     }

tests/Uploader/PluploadTest.php

@@ -118,6 +118,7 @@ public function test_upload_chunk_file()
         $extension = pathinfo($originalName, PATHINFO_EXTENSION);
         $mimeType = finfo_file(finfo_open(FILEINFO_MIME_TYPE), $file);
         $tmpfile = $path.'/'.md5($originalName.$token).'.'.$extension;
+        $tmpfileExtension = Plupload::TMPFILE_EXTENSION;
 
         $chunks = 8;
         $chunk = 7;
@@ -147,7 +148,7 @@ public function test_upload_chunk_file()
 
         $filesystem
             ->shouldReceive('extension')->with($originalName)->andReturn($extension)
-            ->shouldReceive('move')->with($tmpfile.'.part', $tmpfile)
+            ->shouldReceive('move')->with($tmpfile.$tmpfileExtension, $tmpfile)
             ->shouldReceive('size')->with($tmpfile)->andReturn($size);
 
         $uploader = new Plupload($request, $filesystem, $path);
@@ -167,7 +168,7 @@ public function test_upload_chunk_file()
         $request->shouldHaveReceived('get')->with('name')->once();
         $request->shouldHaveReceived('get')->with('token')->once();
         $filesystem->shouldHaveReceived('extension')->with($originalName)->once();
-        $filesystem->shouldHaveReceived('appendStream')->with($tmpfile.'.part', $input, $start)->once();
+        $filesystem->shouldHaveReceived('appendStream')->with($tmpfile.$tmpfileExtension, $input, $start)->once();
         $filesystem->shouldHaveReceived('createUploadedFile')->with($tmpfile, $originalName, $mimeType, $size)->once();
     }