Bugfix: OIDC post login redirects (#2884)

* Added middleware to patch the express redirect function so that no-cache headers are set.
This is because firefox caches redirects which affects our authentication flow

* Added the post login url redirect url from the session into the query string during the oidc auth process so that it persists to the controller where we can use it.

Author: andrewbrazzatti

typescript/api/controllers/UserController.ts

@@ -109,6 +109,8 @@ export module Controllers {
       let postLoginUrl = null;
       if (req.session.redirUrl) {
         postLoginUrl = req.session.redirUrl;
+      } else if (req.query.redirUrl) {
+        postLoginUrl = req.query.redirUrl;
       } else {
         postLoginUrl = `${BrandingService.getBrandAndPortalPath(req)}/${ConfigService.getBrand(branding, 'auth').local.postLoginRedir}`;
       }

typescript/api/services/UsersService.ts

@@ -702,6 +702,11 @@ export module Services {
       } else {
         req.session.logoutUrl = sails.config.auth.postLogoutRedir
       }
+      if(req.session.redirUrl != null) {
+        //the session url changes after login so we lose this value if we don't put it on the queru string
+        req.query.redirUrl = req.session.redirUrl;
+      }
+      
       sails.log.verbose(`OIDC login success, tokenset: `);
       sails.log.verbose(JSON.stringify(tokenSet));
       sails.log.verbose(`Claims:`);