Skip to content

Commit 1001332

Browse files
EPMRPP-67784 & EPMRPP-106324 || Ensure test status reflects failed testAssertion and skipped assertions
1 parent 2101db7 commit 1001332

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

lib/reporter.js

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -322,16 +322,15 @@ class Reporter {
322322

323323
const additionalData = {};
324324

325-
if (testAssertion.skipped) {
326-
additionalData.status = TestStatus.SKIPPED;
327-
if (this.options.skippedIssue === false) {
328-
additionalData.issue = { issueType: 'NOT_ISSUE' };
329-
}
325+
const status = currentStep.status || (testAssertion.skipped ? TestStatus.SKIPPED : (actualError ? TestStatus.FAILED : TestStatus.PASSED));
326+
327+
if (testAssertion.skipped && this.options.skippedIssue === false) {
328+
additionalData.issue = { issueType: 'NOT_ISSUE' };
330329
}
331330

332331
this.client
333332
.finishTestItem(stepObj.tempId, {
334-
status: currentStep.status || (actualError ? TestStatus.FAILED : TestStatus.PASSED),
333+
status,
335334
...additionalData,
336335
})
337336
.promise.catch(errorHandler);
@@ -408,9 +407,11 @@ class Reporter {
408407
this.sendResponseLogs(testObj.testId, testObj.response);
409408
}
410409

410+
const hasFailedAssertions = result.assertions && result.assertions.some(assertion => assertion.error);
411+
411412
this.client
412413
.finishTestItem(testObj.testId, {
413-
status: status || TestStatus.PASSED,
414+
status: status || (hasFailedAssertions ? TestStatus.FAILED : TestStatus.PASSED),
414415
})
415416
.promise.catch(errorHandler);
416417
}

0 commit comments

Comments
 (0)