Skip to content

Commit 28501e6

Browse files
authored
Dev 1185 crear pipeline ngx jsonapi (#374)
1 parent d5ad606 commit 28501e6

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

71 files changed

+6370
-5337
lines changed

.circleci/config.yml

Lines changed: 0 additions & 58 deletions
This file was deleted.

.eslintignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
dist/

.eslintrc.json

Lines changed: 6 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,14 @@
1919
"createDefaultProgram": true
2020
},
2121
"extends": [
22-
"plugin:@angular-eslint/ng-cli-compat",
23-
"plugin:@angular-eslint/ng-cli-compat--formatting-add-on",
24-
"plugin:@angular-eslint/template/process-inline-templates"
22+
"plugin:@angular-eslint/recommended",
23+
"prettier",
24+
"plugin:@typescript-eslint/recommended"
2525
],
2626
"plugins": [
2727
"eslint-plugin-no-null",
2828
"eslint-plugin-unicorn",
29+
"prettier",
2930
"eslint-plugin-rxjs"
3031
],
3132
"rules": {
@@ -149,41 +150,15 @@
149150
"error",
150151
"multi-line"
151152
],
152-
"indent": [
153-
"error",
154-
4,
155-
{
156-
"SwitchCase": 1
157-
}
158-
],
159-
"default-case": "off",
160-
"eol-last": "off",
161-
"guard-for-in": "off",
162-
"import/no-default-export": "off",
163-
"import/no-deprecated": "off",
164-
"import/no-extraneous-dependencies": "off",
165-
"import/no-internal-modules": "off",
166-
"import/no-unassigned-import": "off",
167-
"import/order": "off",
168-
"jsdoc/no-types": "off",
169-
"linebreak-style": "off",
170-
"max-len": "off",
171153
"max-lines": [
172154
"error",
173155
1000
174156
],
175-
"new-parens": "off",
176-
"newline-per-chained-call": "off",
177-
"no-cond-assign": "off",
178157
"no-duplicate-case": "error",
179158
"no-duplicate-imports": "error",
180159
"no-empty": "error",
181160
"no-extra-bind": "error",
182-
"no-extra-semi": "off",
183-
"no-irregular-whitespace": "off",
184-
"no-magic-numbers": "off",
185161
"no-new-func": "error",
186-
"no-null/no-null": "off",
187162
"no-plusplus": [
188163
"error",
189164
{
@@ -199,10 +174,7 @@
199174
"no-sequences": "error",
200175
"no-sparse-arrays": "error",
201176
"no-template-curly-in-string": "error",
202-
"no-trailing-spaces": "off",
203-
"no-useless-constructor": "off",
204177
"no-void": "error",
205-
"object-shorthand": "off",
206178
"padding-line-between-statements": [
207179
"error",
208180
{
@@ -211,11 +183,7 @@
211183
"next": "return"
212184
}
213185
],
214-
"no-underscore-dangle": "off",
215-
"prefer-const": "off",
216186
"prefer-object-spread": "error",
217-
"prefer-template": "off",
218-
"quote-props": "off",
219187
"unicorn/filename-case": [
220188
"error",
221189
{
@@ -230,11 +198,8 @@
230198
"rxjs/no-unsafe-switchmap": "error",
231199
"rxjs/no-unsafe-takeuntil": "error",
232200
"rxjs/throw-error": "error",
233-
"space-before-function-paren": "off",
234-
"space-in-parens": [
235-
"off",
236-
"never"
237-
],
201+
"@typescript-eslint/no-explicit-any": "off",
202+
"indent": "off",
238203
"yoda": "error"
239204
}
240205
},

.github/workflows/config.yml

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
name: version 3
2+
on: [push]
3+
jobs:
4+
build:
5+
name: Build and Test
6+
runs-on: ubuntu-latest
7+
steps:
8+
- uses: actions/checkout@v4
9+
with:
10+
fetch-depth: 0
11+
- name: Use Node 16
12+
uses: actions/setup-node@v4
13+
with:
14+
node-version: '16.x'
15+
- name: Install dependencies
16+
run: yarn install
17+
- name: Prettier check
18+
run: yarn prettier:check
19+
- name: Lint
20+
run: yarn lint
21+
- name: Test
22+
run: yarn test
23+
- name: Build
24+
run: yarn build:jsonapi

.prettierrc.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
// .prettierrc.js
2+
module.exports = {
3+
...require("./node_modules/reyesoft-ci/js/rules/.prettierrc.js"),
4+
printWidth: 140,
5+
tabWidth: 4
6+
};

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
44

55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

7+
## [2.3.1] - 2025-08-01
8+
9+
- Changed CircleCI to GitHub Action and command fix
10+
711
## [Unreleased]
812

913
## [2.3.0-dev-test] - 2023-08-11

angular.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,5 +133,8 @@
133133
"@schematics/angular:directive": {
134134
"prefix": "bc"
135135
}
136+
},
137+
"cli": {
138+
"analytics": false
136139
}
137140
}

build/tasks.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ async function _compilePackagesWithNgc(pkg: string): Promise<void> {
3737
*
3838
* See https://github.com/ngrx/platform/issues/94
3939
*/
40-
let [exportPath, moduleName]: Array<string> = /\/testing$/.test(pkg)
40+
const [exportPath, moduleName]: Array<string> = /\/testing$/.test(pkg)
4141
? [pkg.replace(/(.*\/)testing/i, 'testing'), 'testing']
4242
: [pkg, 'index'];
4343

@@ -283,7 +283,7 @@ export async function removePackagesFolder(config: Config): Promise<void> {
283283
* Deploy build artifacts to repos
284284
*/
285285
export async function publishToRepo(config: Config): Promise<void> {
286-
for (let pkg of util.getTopLevelPackages(config)) {
286+
for (const pkg of util.getTopLevelPackages(config)) {
287287
const SOURCE_DIR: string = `./dist/${pkg}`;
288288
const REPO_URL: string = `git@github.com:ngrx/${pkg}-builds.git`;
289289
const REPO_DIR: string = `./tmp/${pkg}`;

build/util.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ async function runTask(name: string, taskFn: () => Promise<any>): Promise<void>
130130

131131
export function createBuilder(tasks: Array<TaskDef>) {
132132
return async function(config: Config) {
133-
for (let [name, runner] of tasks) {
133+
for (const [name, runner] of tasks) {
134134
await runTask(name, () => runner(config));
135135
}
136136
};

demo/app/app.component.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,7 @@ import { JsonapiCore } from 'ngx-jsonapi';
99
export class AppComponent /* implements OnInit */ {
1010
public loading: string = '';
1111

12-
public constructor(
13-
private jsonapiCore: JsonapiCore
14-
) {
12+
public constructor(private jsonapiCore: JsonapiCore) {
1513
jsonapiCore.loadingsStart = (): void => {
1614
this.loading = 'LOADING...';
1715
};

0 commit comments

Comments
 (0)