feat: Improvements to the plugin installation, so all plugins

Author: Maya Baya

Dockerfile

@@ -26,7 +26,9 @@ ENV AUTO_UPDATE_CRON="0 5 * * TUE" \
     WP_SITE_ADMIN_EMAIL=example@example.org \
     ACCESS_LOG=/dev/stdout \
     ERROR_LOG=/dev/stderr \
-    WORDPRESS_DB_TABLE_PREFIX=wp_
+    WORDPRESS_TABLE_PREFIX=wp_ \
+    WP_INSTALLATION_WAIT_INTERVAL=20 \
+    WP_PLUGINS_REINSTALL_RETRIES=30
 
 # p2 (jinja2)
 RUN wget https://github.com/wrouesnel/p2cli/releases/download/r13/p2-linux-x86_64 -O /usr/bin/p2 && chmod +x /usr/bin/p2

README.md

@@ -80,11 +80,12 @@ services:
             WORDPRESS_DB_USER: "your_user"
             WORDPRESS_DB_PASSWORD: "${DB_PASSWORD_THERE}"
             WORDPRESS_DB_NAME: "your_app"
+            WORDPRESS_TABLE_PREFIX: "wp_"
             AUTO_UPDATE_CRON: "0 5 * * SAT"
             XMLRPC_DISABLED: "true"
             DISABLE_DIRECT_CONTENT_PHP_EXECUTION: "false"
             ENABLED_PLUGINS: "amazon-s3-and-cloudfront"
-          
+
             # basic auth on administrative endpoints
             BASIC_AUTH_ENABLED: "true"
             BASIC_AUTH_USER: john
@@ -116,6 +117,9 @@ WP_SITE_ADMIN_EMAIL: example@example.org
 #         this means that when `WP_PREINSTALL=false`, then the entrypoint will wait for user 
 #         to complete the installation wizard, then the plugins will be installed
 ENABLED_PLUGINS: "amazon-s3-and-cloudfront,classic-editor"
+
+WP_INSTALLATION_WAIT_INTERVAL: 20   # in seconds, how long to wait until the WordPress is installed to start installing plugins
+WP_PLUGINS_REINSTALL_RETRIES: 30    # 30 retries with 20s interval
 ```
 
 **Example log:**
@@ -156,6 +160,13 @@ Plugin installed successfully.
 Success: Installed 1 of 1 plugins.
 ```
 
+### How it works?
+
+- Plugins will be installed AFTER WordPress will be installed. Use `WP_PREINSTALL: true` to install WordPress immediately, else the plugins will be installed after user will finish installation process
+- There will be `WP_PLUGINS_REINSTALL_RETRIES` retries of plugins installation
+- If at least one plugin installation will fail, then **after exceeding maximum number of retries the container will exit**
+- Even if some plugins installation will fail, the rest will be installed (installation process does not exit immediately after first fail)
+
 Keeping wp-content and themes in GIT repository (Kubernetes only)
 -----------------------------------------------------------------
 

container-files/install-plugins-first-time.sh

@@ -1,31 +1,46 @@
 #!/bin/bash
 
 installPlugins() {
+    status=0
+
     IFS=, read -ra plugins <<< "${ENABLED_PLUGINS}"
     for plugin in "${plugins[@]}"; do
         echo " >> Installing plugin '${plugin}'"
-        wp plugin install "${plugin}" || return 1
+        if ! wp plugin install "${plugin}"; then
+            status=1
+        fi
     done
+
+    return ${status}
 }
 
 if [[ "${1}" == "no-wait" ]]; then
     installPlugins
 else
+    retryNum=0
+    retryMaxNum=${WP_PLUGINS_REINSTALL_RETRIES}
+
     while [[ ! -f /var/www/riotkit/wp-content/.plugins-installed ]]; do
         if wp core is-installed; then
             if installPlugins; then
                 echo " >> Plugins installed"
                 break
             else
+                if [[ "$retryNum" -gt "$retryMaxNum" ]]; then
+                    echo " >> Cannot install plugins - maximum retries of ${$retryMaxNum} exceeded"
+                    exit 1
+                fi
+
                 echo " !!! Plugins installation failed"
+                retryNum=$((retryNum+1))
             fi
         else
             echo " ... Waiting for Wordpress to be installed"
         fi
 
-        sleep 20
+        sleep "${WP_INSTALLATION_WAIT_INTERVAL}"
     done
 
-    echo ">> Fuckwork mode on"
+    echo ">> Plugins installed, fuckwork mode on"
     sleep 999999999
 fi

wp-config-sample.php

@@ -58,7 +58,7 @@
  * You can have multiple installations in one database if you give each
  * a unique prefix. Only numbers, letters, and underscores please!
  */
-$table_prefix = isset($_SERVER['WORDPRESS_DB_TABLE_PREFIX']) ? $_SERVER['WORDPRESS_DB_TABLE_PREFIX'] : 'wp_';
+$table_prefix = isset($_SERVER['WORDPRESS_TABLE_PREFIX']) ? $_SERVER['WORDPRESS_TABLE_PREFIX'] : 'wp_';
 
 /**
  * For developers: WordPress debugging mode.