feat: exit on no install eas

Author: dannyhw

.changeset/plenty-toys-pull.md

@@ -0,0 +1,5 @@
+---
+'create-expo-stack': patch
+---
+
+exits when eas and no install are chosen together since its not possible

cli/src/utilities/printOutput.ts

@@ -5,40 +5,7 @@ import { AvailablePackages, CliResults } from '../types';
 import { copyBaseAssets } from './copyBaseAssets';
 import { outro, spinner } from '@clack/prompts';
 import { easConfigure } from './runEasConfigure';
-
-type STDIO = 'inherit' | 'ignore' | 'pipe' | 'overlapped';
-
-const onlyErrors = ['ignore', 'ignore', 'inherit'] as const;
-
-async function runSystemCommand({
-  command,
-  errorMessage,
-  stdio,
-  toolbox
-}: {
-  command: string;
-  toolbox: Toolbox;
-  stdio: readonly [STDIO, STDIO, STDIO] | STDIO | undefined;
-  errorMessage: string;
-}) {
-  const {
-    print: { error },
-    system
-  } = toolbox;
-
-  const result = await system.spawn(command, {
-    shell: true,
-    stdio
-  });
-
-  if (result.error || result.status !== 0) {
-    error(`${errorMessage}: ${JSON.stringify(result)}`);
-
-    error(`failed to run command: ${command}`);
-
-    return process.exit(1);
-  }
-}
+import { ONLY_ERRORS, runSystemCommand } from './systemCommand';
 
 export async function printOutput(
   cliResults: CliResults,
@@ -78,7 +45,7 @@ export async function printOutput(
     await runSystemCommand({
       toolbox,
       command: `cd ${projectName} && ${packageManager} install --silent`,
-      stdio: packageManager === 'npm' ? undefined : onlyErrors,
+      stdio: packageManager === 'npm' ? undefined : ONLY_ERRORS,
       errorMessage: 'Error installing dependencies'
     });
 
@@ -91,7 +58,7 @@ export async function printOutput(
     await runSystemCommand({
       toolbox,
       command: `cd ${projectName} && ${packageManager} ${installCommand} --silent expo@latest`,
-      stdio: isNpm ? undefined : onlyErrors,
+      stdio: isNpm ? undefined : ONLY_ERRORS,
       errorMessage: 'Error updating expo'
     });
 
@@ -129,7 +96,7 @@ export async function printOutput(
       toolbox,
       command: `${runnerType} prettier "${projectName}/**/*.{json,js,jsx,ts,tsx}" --no-config --write`,
       errorMessage: 'Error formatting code',
-      stdio: onlyErrors
+      stdio: ONLY_ERRORS
     });
 
     s.stop('Project files formatted!');

cli/src/utilities/runEasConfigure.ts

@@ -1,17 +1,24 @@
 import { Toolbox } from 'gluegun/build/types/domain/toolbox';
 import { cancel, confirm, isCancel, select } from '@clack/prompts';
 import { CliResults, PackageManager } from '../types';
+import { runSystemCommand } from './systemCommand';
 
 export async function easConfigure(
   cliResults: CliResults,
   packageManager: PackageManager,
   toolbox: Toolbox
 ): Promise<void> {
   const {
-    print: { info, success, error, warning },
+    print: { info, success, warning, error },
     system
   } = toolbox;
 
+  if (cliResults.flags.noInstall) {
+    error('Eas configuration requires installing dependencies, please remove the --no-install flag and try again.');
+
+    process.exit(1);
+  }
+
   const { projectName } = cliResults;
 
   info('Configuring EAS...');
@@ -55,38 +62,33 @@ export async function easConfigure(
 
       info(`We'll use ${packageManagerToUse} install -g eas-cli`);
       info(``);
-      const result = await system.spawn(`${packageManagerToUse} install -g eas-cli`);
 
-      if (result.error) {
-        error('Error installing EAS CLI');
-        return process.exit(1);
-      }
+      await runSystemCommand({
+        command: `${packageManagerToUse} install -g eas-cli`,
+        toolbox,
+        errorMessage: 'Error installing EAS CLI',
+        stdio: undefined
+      });
     }
   }
 
-  const result = await system.spawn(`cd ${projectName} && eas build:configure -p all`, {
-    shell: true,
-    stdio: 'inherit'
+  await runSystemCommand({
+    command: `cd ${projectName} && eas build:configure -p all`,
+    errorMessage: 'Error configuring EAS',
+    stdio: 'inherit',
+    toolbox
   });
 
-  if (result.error || result.status !== 0) {
-    error('Error configuring EAS');
-    return process.exit(1);
-  }
-
   success('EAS configured!');
 
   info(`Now we'll generate the native code for your project`);
 
-  const preBuildResult = await system.spawn(`cd ${projectName} && ${packageManager} run prebuild`, {
-    shell: true,
-    stdio: 'inherit'
+  await runSystemCommand({
+    command: `cd ${projectName} && ${packageManager} run prebuild`,
+    errorMessage: 'Error generating native code',
+    stdio: 'inherit',
+    toolbox
   });
 
-  if (preBuildResult.error || preBuildResult.status !== 0) {
-    error('Error generating native code');
-    return process.exit(1);
-  }
-
   success('Native code generated!');
 }

cli/src/utilities/systemCommand.ts

@@ -0,0 +1,35 @@
+import { Toolbox } from 'gluegun/build/types/domain/toolbox';
+
+type STDIO = 'inherit' | 'ignore' | 'pipe' | 'overlapped';
+
+export const ONLY_ERRORS = ['ignore', 'ignore', 'inherit'] as const;
+
+export async function runSystemCommand({
+  command,
+  errorMessage,
+  stdio,
+  toolbox
+}: {
+  command: string;
+  toolbox: Toolbox;
+  stdio: readonly [STDIO, STDIO, STDIO] | STDIO | undefined;
+  errorMessage: string;
+}) {
+  const {
+    print: { error },
+    system
+  } = toolbox;
+
+  const result = await system.spawn(command, {
+    shell: true,
+    stdio
+  });
+
+  if (result.error || result.status !== 0) {
+    error(`${errorMessage}: ${JSON.stringify(result)}`);
+
+    error(`failed to run command: ${command}`);
+
+    return process.exit(1);
+  }
+}