Fixes 192: Use file.copy for cross-disk flexibility in HYDAT download

Replaced file.rename with file.copy to handle situations where the temp folder and the destination are on different physical disks (e.g. Docker container with different mount points for the tempdir and the destination).

Author: mpdavison

R/download.R

@@ -121,7 +121,7 @@ download_hydat <- function(dl_hydat_here = NULL, ask = TRUE) {
     on.exit(unlink(tempdir, recursive = TRUE))
 
     ## Move to final resting place and rename to consistent name
-    file.rename(
+    file.copy(
       list.files(tempdir, pattern = "\\.sqlite3$", full.names = TRUE),
       hydat_path
     )