Skip to content

Commit 38d7f12

Browse files
nlampriantraversaro
authored andcommitted
Support name attribute for collisions (#67)
1 parent 3dc9766 commit 38d7f12

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

src/urdf_parser_py/urdf.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,12 +149,14 @@ def write_xml(self, node, obj):
149149

150150

151151
class Collision(xmlr.Object):
152-
def __init__(self, geometry=None, origin=None):
152+
def __init__(self, geometry=None, origin=None, name=None):
153153
self.geometry = geometry
154+
self.name = name
154155
self.origin = origin
155156

156157

157158
xmlr.reflect(Collision, tag='collision', params=[
159+
xmlr.Attribute('name', str, False),
158160
origin_element,
159161
xmlr.Element('geometry', 'geometric')
160162
])

test/test_urdf.py

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,19 @@ def test_link_multiple_collision(self):
195195
</robot>'''
196196
self.parse_and_compare(xml)
197197

198+
def test_collision_with_name(self):
199+
xml = '''<?xml version="1.0"?>
200+
<robot name="test" version="1.0">
201+
<link name="link">
202+
<collision name="alice">
203+
<geometry>
204+
<cylinder length="1" radius="1"/>
205+
</geometry>
206+
</collision>
207+
</link>
208+
</robot>'''
209+
self.parse_and_compare(xml)
210+
198211
def test_version_attribute_not_enough_dots(self):
199212
xml = '''<?xml version="1.0"?>
200213
<robot name="test" version="1">

0 commit comments

Comments
 (0)