Eliminate warnings and other minor cleanups

Author: ruven

.github/workflows/c-cpp.yml

@@ -13,7 +13,7 @@ jobs:
     - uses: actions/checkout@v4
 
     - name: Install dependencies
-      run:  sudo apt-get update && sudo apt-get install libtiff-dev libpng-dev libturbojpeg-dev libwebp-dev libavif-dev libmemcached-dev libopenjp2-7-dev
+      run:  sudo apt-get update && sudo apt-get install libfcgi-dev libtiff-dev libpng-dev libturbojpeg-dev libwebp-dev libavif-dev libmemcached-dev libopenjp2-7-dev
 
     - name: Configure
       run: |

configure.ac

@@ -314,10 +314,6 @@ if test -n "$kakadu_path"; then
 
 		AC_SUBST(KAKADU_OBJS)
 
-		AC_LANG_PUSH([C++])
-		AC_CHECK_HEADER([thread], [AC_DEFINE(HAVE_STL_THREAD)])
-		AC_LANG_POP([C++])
-
 		AC_CHECK_FUNC([get_nprocs_conf],[AC_DEFINE(NPROCS)])
 	fi
 else

src/JPEGImage.cc

@@ -16,7 +16,6 @@
     along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-
 #include "JPEGImage.h"
 #include "Logger.h"
 #include <cstdio>
@@ -476,8 +475,8 @@ void JPEGImage::process( unsigned int res, int layers, int xoffset, int yoffset,
       }
     }
 
-    // Free any temporary buffer we may have created
-    if( dst_ptr ) free( dst_ptr );
+    // Free temporary buffer we created for when factor > 1
+    if( buffer ) free( buffer );
   }
 
 }

src/TIFFCompressor.cc

@@ -41,7 +41,7 @@ extern "C" {
     tiff_mem *memtif = (tiff_mem *) handle;
 
     // Re-allocate extra memory if we don't have enough space
-    if( ((tsize_t) memtif->current + length) > memtif->capacity ){
+    if( (memtif->current + length) > memtif->capacity ){
       memtif->capacity = memtif->capacity + length;
       memtif->buffer = (unsigned char*) realloc( memtif->buffer, memtif->capacity );
     }
@@ -94,11 +94,6 @@ extern "C" {
   static void _unmap( thandle_t handle, tdata_t base, toff_t psize ){
   }
 
-  // Free function - unimplemented as memory handled manually
-  static void _free( tiff_mem *memtif ){
-    return;
-  }
-
 }
 
 

src/TIFFCompressor.h

@@ -33,7 +33,7 @@ typedef struct {
   unsigned char *buffer;   /// Data buffer
   toff_t current;          /// Current byte position within stream
   toff_t end;              /// Last written byte
-  tsize_t capacity;        /// Allocated buffer size
+  toff_t capacity;         /// Allocated buffer size
 } tiff_mem;
 
 typedef tiff_mem* tiff_mem_ptr;

src/Task.cc

@@ -99,7 +99,7 @@ void QLT::run( Session* session, const string& argument ){
   transform( arg.begin(), arg.end(), arg.begin(), ::tolower );
 
   // Check whether we have a compression:quality combination
-  int delimitter = arg.find( ":" );
+  std::string::size_type delimitter = arg.find( ":" );
   if( delimitter != string::npos ){
     string comp = arg.substr( 0, delimitter );
     int                          compression = 0;