Skip to content

Commit 1a9af35

Browse files
committed
Fix tests
1 parent f4a409e commit 1a9af35

File tree

4 files changed

+28
-20
lines changed

4 files changed

+28
-20
lines changed

crates/abq_cli/src/workers.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -178,11 +178,11 @@ async fn do_shutdown(
178178

179179
let (suite_result, errors) = finalized_reporters.finish(&completed_summary);
180180

181-
if let WorkersExitStatus::Completed { .. } = status {
182-
for error in errors {
183-
eprintln!("{error}");
184-
}
181+
for error in errors {
182+
eprintln!("{error}");
183+
}
185184

185+
if matches!(status, WorkersExitStatus::Completed { .. }) || suite_result.count > 0 {
186186
print!("\n\n");
187187
suite_result
188188
.write_short_summary_lines(&mut stdout, ShortSummaryGrouping::Runner)

crates/abq_queue/src/queue.rs

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,6 +291,8 @@ enum ReadResultsError {
291291
RunNotFound,
292292
#[error("results cannot be read before manifest is received")]
293293
WaitingForManifest,
294+
#[error("a manifest failed to be generated")]
295+
ManifestNeverReceived,
294296
#[error("the run was cancelled before all test results were received")]
295297
RunCancelled,
296298
}
@@ -983,7 +985,13 @@ impl AllRuns {
983985
}
984986
}
985987
}
986-
RunState::Cancelled { .. } => Err(RunCancelled),
988+
RunState::Cancelled { reason } => {
989+
match reason {
990+
CancelReason::User => Err(RunCancelled),
991+
CancelReason::ManifestHadNoProgress => Err(RunCancelled),
992+
CancelReason::ManifestNeverReceived => Err(ManifestNeverReceived),
993+
}
994+
}
987995
}
988996
}
989997

crates/abq_queue/tests/integration.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1646,7 +1646,7 @@ async fn test_cancellation_drops_remaining_work() {
16461646
[
16471647
WorkerExitStatus(
16481648
Wid(2),
1649-
Box::new(|e| assert_eq!(e, &WorkersExitStatus::Completed(ExitCode::CANCELLED))),
1649+
Box::new(|e| assert_eq!(e, &WorkersExitStatus::Error { errors: vec![String::from("Error: This ABQ run was cancelled. When an ABQ run is cancelled, it can no longer be retried. You must start a run with a new run ID instead.\nThis run was cancelled because a worker received a cancellation signal while still working on tests.")] })),
16501650
),
16511651
QueueTestResults(
16521652
Run(1),

crates/reporters/progress/src/lib.rs

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -358,59 +358,59 @@ mod test {
358358
<bold>> ABQ status<reset>
359359
<bold>> [0 seconds] 1 tests run<reset>, <green-bold>1 passed<reset>, <reset>0 failing<reset>
360360
361-
361+
362362
<bold>> ABQ status<reset>
363363
<bold>> [0 seconds] 1 tests run<reset>, <green-bold>1 passed<reset>, <reset>0 failing<reset>
364364
365-
365+
366366
<bold>> ABQ status<reset>
367367
<bold>> [0 seconds] 1 tests run<reset>, <green-bold>1 passed<reset>, <reset>0 failing<reset>
368368
369-
369+
370370
<bold>> ABQ status<reset>
371371
<bold>> [0 seconds] 2 tests run<reset>, <green-bold>1 passed<reset>, <red-bold>1 failing<reset>
372372
373-
373+
374374
<bold>> ABQ status<reset>
375375
<bold>> [0 seconds] 2 tests run<reset>, <green-bold>1 passed<reset>, <red-bold>1 failing<reset>
376376
377-
377+
378378
<bold>> ABQ status<reset>
379379
<bold>> [0 seconds] 2 tests run<reset>, <green-bold>1 passed<reset>, <red-bold>1 failing<reset>
380380
381-
381+
382382
<bold>> ABQ status<reset>
383383
<bold>> [0 seconds] 3 tests run<reset>, <green-bold>2 passed<reset>, <red-bold>1 failing<reset>
384384
385-
385+
386386
<bold>> ABQ status<reset>
387387
<bold>> [0 seconds] 3 tests run<reset>, <green-bold>2 passed<reset>, <red-bold>1 failing<reset>
388388
389-
389+
390390
<bold>> ABQ status<reset>
391391
<bold>> [0 seconds] 3 tests run<reset>, <green-bold>2 passed<reset>, <red-bold>1 failing<reset>
392392
393-
393+
394394
<bold>> ABQ status<reset>
395395
<bold>> [0 seconds] 4 tests run<reset>, <green-bold>2 passed<reset>, <red-bold>2 failing<reset>
396396
397-
397+
398398
<bold>> ABQ status<reset>
399399
<bold>> [0 seconds] 4 tests run<reset>, <green-bold>2 passed<reset>, <red-bold>2 failing<reset>
400400
401-
401+
402402
<bold>> ABQ status<reset>
403403
<bold>> [0 seconds] 4 tests run<reset>, <green-bold>2 passed<reset>, <red-bold>2 failing<reset>
404404
405-
405+
406406
<bold>> ABQ status<reset>
407407
<bold>> [0 seconds] 5 tests run<reset>, <green-bold>3 passed<reset>, <red-bold>2 failing<reset>
408408
409-
409+
410410
<bold>> ABQ status<reset>
411411
<bold>> [0 seconds] 5 tests run<reset>, <green-bold>3 passed<reset>, <red-bold>2 failing<reset>
412412
413-
413+
414414
"###);
415415
}
416416

0 commit comments

Comments
 (0)