s3:lib: Fix CID 1497484 use-after-free.

Vinit Agnihotri · gd · commit 16201d541512 · 2025-07-29T15:01:42.000Z
p was not set to NULL after being free'd, this can cause a
use-after-free situation.

This fixes coverity issue#1497484

Signed-off-by: Vinit Agnihotri &lt;vagnihot@redhat.com&gt;
Reviewed-by: Guenther Deschner &lt;gd@samba.org&gt;
Reviewed-by: Anoop C S &lt;anoopcs@samba.org&gt;

Autobuild-User(master): Günther Deschner &lt;gd@samba.org&gt;
Autobuild-Date(master): Tue Jul 29 15:01:42 UTC 2025 on atb-devel-224
diff --git a/source3/lib/netapi/examples/common.c b/source3/lib/netapi/examples/common.c
@@ -156,6 +156,7 @@ char *netapi_read_file(const char *filename, uint32_t *psize)
 	err = ferror(file);
 	if (err != 0) {
 		free(p);
+		p = NULL;
 		goto fail;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -156,6 +156,7 @@ char netapi_read_file(const char filename, uint32_t *psize)`
`156`	`156`	`err = ferror(file);`
`157`	`157`	`if (err != 0) {`
`158`	`158`	`free(p);`
	`159`	`+ p = NULL;`
`159`	`160`	`goto fail;`
`160`	`161`	`}`
`161`	`162`