Merge pull request #10 from sander3/data-retention-feature

sander3 · web-flow · commit 81ccebfaf3b4 · 2018-06-04T11:13:27.000+02:00
Missing comment and type hinting added
diff --git a/src/Jobs/Cleanup/CleanupJob.php b/src/Jobs/Cleanup/CleanupJob.php
@@ -19,7 +19,7 @@ class CleanupJob implements ShouldQueue
     public $users;
 
     /**
-     * @var
+     * @var \Soved\Laravel\Gdpr\Jobs\Cleanup\CleanupStrategy
      */
     public $strategy;
 
diff --git a/src/Retentionable.php b/src/Retentionable.php
@@ -2,14 +2,16 @@
 
 namespace Soved\Laravel\Gdpr;
 
+use Carbon\Carbon;
+
 trait Retentionable
 {
     /**
      * Get the user's last activity.
      *
      * @return \Illuminate\Support\Carbon
      */
-    public function getLastActivityAttribute()
+    public function getLastActivityAttribute(): Carbon
     {
         return $this->updated_at;
     }

Original file line number	Diff line number	Diff line change
`@@ -2,14 +2,16 @@`
`2`	`2`
`3`	`3`	`namespace Soved\Laravel\Gdpr;`
`4`	`4`
	`5`	`+use Carbon\Carbon;`
	`6`	`+`
`5`	`7`	`trait Retentionable`
`6`	`8`	`{`
`7`	`9`	`/**`
`8`	`10`	`* Get the user's last activity.`
`9`	`11`	`*`
`10`	`12`	`* @return \Illuminate\Support\Carbon`
`11`	`13`	`*/`
`12`		`- public function getLastActivityAttribute()`
	`14`	`+ public function getLastActivityAttribute(): Carbon`
`13`	`15`	`{`
`14`	`16`	`return $this->updated_at;`
`15`	`17`	`}`